[GitHub] [incubator-druid] clintropolis opened a new issue #8256: refactor filters

[GitBox <gi...@apache.org>]

clintropolis opened a new issue #8256: refactor filters
URL: https://github.com/apache/incubator-druid/issues/8256
 
 
   ### Description
   `DimFilter` has a lot of repeated code between different implementations due to everything having an `extractionFn` and soon, a `filterTuning` following #8209. See [this comment](https://github.com/apache/incubator-druid/pull/8209#discussion_r311680045), and this is semi-related to #8242 in that it is suggesting a path to remove `extractionFn` from `DimFilter` so coordination is probably required.
   
   Additionally, I think `DimFilter` and `Filter` can be combined, I understand they exist as separate entities so that `DimFilter` could be a light-weight 'client' object that was unaware of selectors and such, but this doesn't seem necessary with the current design of things and there is a lot of redundant stuff going on here that could be improved.
   
   Finally, there is some room for improvements in how tests are creating `DimFilters`, so static methods to create filters for testing so passing in `null` for `extractionFn` and `filterTuning` should be added to decouple tests from the json schema of filters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org