You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/03 02:27:45 UTC
[GitHub] [kafka] dengziming opened a new pull request #10033: MINOR: Fix always pass unit test in MetadataRequestTest
dengziming opened a new pull request #10033:
URL: https://github.com/apache/kafka/pull/10033
*More detailed description of your change*
`Seq[Int].contains(KafkaServer)` will always be false, we should use `Seq[Int].contains(KafkaServer.config.brokerId)`
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #10033: MINOR: Fix always pass unit test in MetadataRequestTest
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10033:
URL: https://github.com/apache/kafka/pull/10033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #10033: MINOR: Fix always pass unit test in MetadataRequestTest
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10033:
URL: https://github.com/apache/kafka/pull/10033#issuecomment-773049174
@chia7712 Done! The failures seemed unrelated to this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10033: MINOR: Fix always pass unit test in MetadataRequestTest
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10033:
URL: https://github.com/apache/kafka/pull/10033#issuecomment-773049664
Merge to trunk and thanks for your patch @dengziming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10033: MINOR: Fix always pass unit test in MetadataRequestTest
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10033:
URL: https://github.com/apache/kafka/pull/10033#issuecomment-772600444
@dengziming Those failures should be unrelated to your PR but it would be better to see green QA before merging. Hence, could you merge trunk to trigger QA again? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org