You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/05/12 03:34:41 UTC

Review Request: SQOOP-1042 Sqoop2: Name constraints in Derby repository

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11071/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added explicit constraint names.


This addresses bug SQOOP-1042.
    https://issues.apache.org/jira/browse/SQOOP-1042


Diffs
-----

  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java e1b1128cfcfa38d095096067629c37a585646f47 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 24f86eee7a084997194dd0f9421297d6b9839e49 

Diff: https://reviews.apache.org/r/11071/diff/


Testing
-------

Both unit and integration tests seems to be passing.


Thanks,

Jarek Cecho

Re: Review Request: SQOOP-1042 Sqoop2: Name constraints in Derby repository

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11071/#review20460
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On May 12, 2013, 1:34 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11071/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 1:34 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added explicit constraint names.
> 
> 
> This addresses bug SQOOP-1042.
>     https://issues.apache.org/jira/browse/SQOOP-1042
> 
> 
> Diffs
> -----
> 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java e1b1128cfcfa38d095096067629c37a585646f47 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 24f86eee7a084997194dd0f9421297d6b9839e49 
> 
> Diff: https://reviews.apache.org/r/11071/diff/
> 
> 
> Testing
> -------
> 
> Both unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>