You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:53:59 UTC
[GitHub] [avro] RyanSkraba commented on a change in pull request #910: AVRO-2859: Add Version Number for Spotless Plugin
RyanSkraba commented on a change in pull request #910:
URL: https://github.com/apache/avro/pull/910#discussion_r436843657
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
```suggestion
<versionRange>${spotless-maven-plugin.version}</versionRange>
```
Hello! Good catch, but I couldn't get it to work with `<version>`, did you mean `<versionRange>` ?
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
I'm glad someone is looking out for working in Eclipse :D Happy devs make happy software!
I don't use Eclipse as often, so I tested with Eclipse 2020-03 and still couldn't successfully build after your change.
I just did **File** / **Import** / **Existing Maven Projects** and pointed to the top-level `pom.xml` and got a bunch of these errors:
`Cannot parse lifecycle mapping metadata for maven project MavenProject: org.apache.avro:avro-parent:1.11.0-SNAPSHOT @ /home/rskraba/working/github/avro/lang/java/pom.xml Cause: Unrecognised tag: 'version' (position: START_TAG seen ...</artifactId>\n <version>... @8:18) pom.xml /avro-ipc-netty line 1`
It works if the XML tag added to the pom is `<versionRange>`, which is why I asked. Am I doing something wrong while checking this?
##########
File path: lang/java/pom.xml
##########
@@ -361,6 +361,7 @@
<pluginExecutionFilter>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
+ <version>${spotless-maven-plugin.version}</version>
Review comment:
I still have the same error on Eclipse 2019-06 -- if `<version>` (or both) is present, the Maven Project Build Lifecycle Mapping fails! This is Fedora 32 by the way.
In any case, the maven import to eclipse is definitely broken as it is, and slightly less broken (even for me!) after the PR. Let's merge it, or get someone else to try? Either way, I have more confidence in your setup than mine!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org