You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "AutomationDev85 (via GitHub)" <gi...@apache.org> on 2024/11/14 10:17:30 UTC
[PR] BaseExecutor allows executors to consumer task_instance parameters [airflow]
AutomationDev85 opened a new pull request, #44016:
URL: https://github.com/apache/airflow/pull/44016
# Description
During implementation of the slot handling in the Edge provider package (see https://github.com/apache/airflow/pull/43737) a discussion about how to enable executors to use additional information was started. This PR tackles the idea on extend the execute_async function with task_instance to allow executor consuming all the task_instance parameters. With this it is pretty simple to change a the interface and the executer can decide with task_instance parameters he wants to use to implement task specific behaviors.
This PR show a possible solution how to handle option 2 in this discussion in this PR https://github.com/apache/airflow/pull/43737. Will also create a devlist discussion about this.
# Details about changes
* Add execute function into BaseExecutor which has task_instance as parameter.
* New execute function calls old execute_async function to keep not updated Executors running.
* Add deprecation warning for Executor which use the old execute_async function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BaseExecutor allows executors to consumer task_instance parameters [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44016:
URL: https://github.com/apache/airflow/pull/44016#issuecomment-2505139905
Yes. It's cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BaseExecutor allows executors to consumer task_instance parameters [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #44016:
URL: https://github.com/apache/airflow/pull/44016#issuecomment-2477264542
Even though it is green, converting to DRAFT as long as devlist discussion is ongoing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BaseExecutor allows executors to consumer task_instance parameters [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #44016: BaseExecutor allows executors to consumer task_instance parameters
URL: https://github.com/apache/airflow/pull/44016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BaseExecutor allows executors to consumer task_instance parameters [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #44016:
URL: https://github.com/apache/airflow/pull/44016#issuecomment-2506806086
> Yes. It's cool.
I assume we can drop this as in AIP-72 the interface is changing anyway as far as I understood @ashb - and will not go into 2.10-line.
@AutomationDev85 is thi sstill something that is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] BaseExecutor allows executors to consumer task_instance parameters [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44016:
URL: https://github.com/apache/airflow/pull/44016#issuecomment-2585982208
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org