You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/05/10 06:13:43 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

AngersZhuuuu opened a new pull request, #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370

   ### What changes were proposed in this pull request?
   Support rack aware during assign slots for ROUNDROBIN
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1482412021

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1370](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a1b2a7) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/f16c7b414e23fbc4efa6ec6c67a5e9844c4fbdb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f16c7b4) will **increase** coverage by `0.01%`.
   > The diff coverage is `20.59%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1370      +/-   ##
   ============================================
   + Coverage     29.81%   29.81%   +0.01%     
   + Complexity      917      909       -8     
   ============================================
     Files           222      222              
     Lines         18533    18514      -19     
     Branches       1978     1975       -3     
   ============================================
   - Hits           5523     5518       -5     
   + Misses        12620    12604      -16     
   - Partials        390      392       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...celeborn/common/network/CelebornRackResolver.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL25ldHdvcmsvQ2VsZWJvcm5SYWNrUmVzb2x2ZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...apache/celeborn/service/deploy/master/Master.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvbWFzdGVyL01hc3Rlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `65.02% <5.27%> (-6.18%)` | :arrow_down: |
   | [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `81.51% <85.72%> (+0.07%)` | :arrow_up: |
   
   ... and [10 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1370/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1193397193


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -46,8 +48,8 @@ class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {
     }
   }
 
-  def resolve(hostName: String): String = {
-    coreResolve(Seq(hostName)).head.getNetworkLocation
+  def resolve(hostName: String): Node = {

Review Comment:
   > It's better to cache the hostName -> Node in this class to avoid resolve every time.
   
   The underline implement is `CachedDNSToSwitchMapping`, so we don't need to do this here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1552400894

   > This PR looks good to me as long as default to false :)
   
   Yea, it should be false by default. But it can really help for unstable network env....
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1547379266

    I’ll review this PR today.
   
   在 2023年5月15日 16:02:42 上,Keyong Zhou ***@***.***> 写道:
   
   > ping @FMX <https://github.com/FMX> , could you take a look at this PR?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1547377328>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AA7VNUOUPLTXU2SE6ILN2ILXGHPKFANCNFSM6AAAAAAWCJINV4>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1197357639


##########
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala:
##########
@@ -40,6 +40,7 @@ class WorkerInfo(
     val userResourceConsumption: util.Map[UserIdentifier, ResourceConsumption],
     var endpoint: RpcEndpointRef) extends Serializable with Logging {
   var unknownDiskSlots = new java.util.HashMap[String, Integer]()
+  var networkLocation = "/default-rack"

Review Comment:
   It is actually a rack location. How about a clear and meaningful name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1548875484

   Any more suggestion?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1549266618

   ping @waitinfuture @FMX Could you take a look again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1548938136

   Due to the discussion, this PR will need some changes for non-hadoop environments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1552372346

   Test in reg ENV. 
   <img width="877" alt="截屏2023-05-18 下午12 03 50" src="https://github.com/apache/incubator-celeborn/assets/46485123/50fb7479-0450-4a47-98f5-901972ca3d67">
   Before 
   <img width="1792" alt="截屏2023-05-18 上午11 13 19" src="https://github.com/apache/incubator-celeborn/assets/46485123/8dc7992a-88a9-473f-92cf-bb694a6e7ceb">
   
   After.
   <img width="1792" alt="截屏2023-05-18 下午12 03 38" src="https://github.com/apache/incubator-celeborn/assets/46485123/71030a32-decd-4329-ad44-df126673e6bb">
   
   cc @waitinfuture @FMX @RexXiong 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] github-actions[bot] commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1519624143

   This issue was closed because it has been staled for 10 days with no activity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1193286191


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java:
##########
@@ -238,6 +253,23 @@ private static List<Integer> roundRobin(
     return partitionIdList;
   }
 
+  private static boolean haveUsableSlots(
+      Map<WorkerInfo, List<UsableDiskInfo>> restrictions, List<WorkerInfo> workers, int index) {
+    return restrictions.get(workers.get(index)).stream().mapToLong(i -> i.usableSlots).sum() > 0;
+  }
+
+  private static boolean satisfyRackAware(
+      CelebornRackResolver rackResolver,
+      List<WorkerInfo> workers,
+      int masterIndex,
+      int nextSlaveInd) {
+    return rackResolver == null
+        || !rackResolver.enabledRackAware()
+        || rackResolver.getDistance(

Review Comment:
   I think we can just check if the two nodes have the same parent, like ```NetworkTopology.isOnSameRack``` in hadoop 3.2.1
   ```
     public boolean isOnSameRack( Node node1,  Node node2) {
       if (node1 == null || node2 == null) {
         return false;
       }
         
       netlock.readLock().lock();
       try {
         return isSameParents(node1, node2);
       } finally {
         netlock.readLock().unlock();
       }
     }
   ```



##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -46,8 +48,8 @@ class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {
     }
   }
 
-  def resolve(hostName: String): String = {
-    coreResolve(Seq(hostName)).head.getNetworkLocation
+  def resolve(hostName: String): Node = {

Review Comment:
   It's better to cache the hostName -> Node in this class to avoid resolve every time.



##########
master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java:
##########
@@ -144,9 +154,11 @@ static class UsableDiskInfo {
             partitionIds,
             new ArrayList<>(restriction.keySet()),
             restriction,
-            shouldReplicate);
+            shouldReplicate,
+            rackResolver);
     if (!remainPartitions.isEmpty()) {
-      roundRobin(slots, remainPartitions, new ArrayList<>(workers), null, shouldReplicate);
+      roundRobin(

Review Comment:
   This call here does't guarantee slots will be allocated if rackAware is enabled. We should do as ```offerSlotsRoundRobin``` does, or we just pass null as rackResolver, and theses two places should be consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1196080598


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {

Review Comment:
   > Why LifecycleManager will use this? It will be too heavy for client. Maybe we can call offerSlots to revive if rackawareness is enabled.
   
   Current code add networkLocation into worker info, LifecycleManager direct use the information



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1547151364

   > BTW, it may hurt performance if two replicas are on different racks.
   
   Yea, so disable it by default


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1193499799


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java:
##########
@@ -238,6 +253,23 @@ private static List<Integer> roundRobin(
     return partitionIdList;
   }
 
+  private static boolean haveUsableSlots(
+      Map<WorkerInfo, List<UsableDiskInfo>> restrictions, List<WorkerInfo> workers, int index) {
+    return restrictions.get(workers.get(index)).stream().mapToLong(i -> i.usableSlots).sum() > 0;
+  }
+
+  private static boolean satisfyRackAware(
+      CelebornRackResolver rackResolver,
+      List<WorkerInfo> workers,
+      int masterIndex,
+      int nextSlaveInd) {
+    return rackResolver == null
+        || !rackResolver.enabledRackAware()
+        || rackResolver.getDistance(

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1552395890

   > Test in reg ENV. <img alt="截屏2023-05-18 下午12 03 50" width="877" src="https://user-images.githubusercontent.com/46485123/239136274-50fb7479-0450-4a47-98f5-901972ca3d67.png"> Before <img alt="截屏2023-05-18 上午11 13 19" width="1792" src="https://user-images.githubusercontent.com/46485123/239136304-8dc7992a-88a9-473f-92cf-bb694a6e7ceb.png">
   > 
   > After. <img alt="截屏2023-05-18 下午12 03 38" width="1792" src="https://user-images.githubusercontent.com/46485123/239136422-71030a32-decd-4329-ad44-df126673e6bb.png">
   > 
   > cc @waitinfuture @FMX @RexXiong
   
   This PR looks good to me as long as default to false :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] github-actions[bot] commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1506564901

   This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1193400421


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java:
##########
@@ -144,9 +154,11 @@ static class UsableDiskInfo {
             partitionIds,
             new ArrayList<>(restriction.keySet()),
             restriction,
-            shouldReplicate);
+            shouldReplicate,
+            rackResolver);
     if (!remainPartitions.isEmpty()) {
-      roundRobin(slots, remainPartitions, new ArrayList<>(workers), null, shouldReplicate);
+      roundRobin(

Review Comment:
   Good catch, changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1194572611


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {

Review Comment:
   > How about moving this class to master module? I found that our common module contains too much content.
   
   Also need use this in LifecycleManager's reallocate logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1194857461


##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -261,7 +261,7 @@ private[celeborn] class Master(
           userResourceConsumption,
           requestId))
 
-    case requestSlots @ RequestSlots(_, _, _, _, _, _, _) =>
+    case requestSlots @ RequestSlots(_, _, _, _, _, _, _, _) =>

Review Comment:
   I wonder if requests from old clients can be matched or not. Here needs some verification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1541617828

   ping @waitinfuture @RexXiong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1197409016


##########
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala:
##########
@@ -40,6 +40,7 @@ class WorkerInfo(
     val userResourceConsumption: util.Map[UserIdentifier, ResourceConsumption],
     var endpoint: RpcEndpointRef) extends Serializable with Logging {
   var unknownDiskSlots = new java.util.HashMap[String, Integer]()
+  var networkLocation = "/default-rack"

Review Comment:
   Considering this name is widely-used it's OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX merged pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1545506078

   Any suggestion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1545625322

   I will review this PR in the following two days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] github-actions[bot] closed pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN
URL: https://github.com/apache/incubator-celeborn/pull/1370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1196076821


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {

Review Comment:
   Why LifecycleManager will use this? It will be too heavy for client. Maybe we can call offerSlots to revive if rackawareness is enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1197357639


##########
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala:
##########
@@ -40,6 +40,7 @@ class WorkerInfo(
     val userResourceConsumption: util.Map[UserIdentifier, ResourceConsumption],
     var endpoint: RpcEndpointRef) extends Serializable with Logging {
   var unknownDiskSlots = new java.util.HashMap[String, Integer]()
+  var networkLocation = "/default-rack"

Review Comment:
   It it actually rack location. How about a clear and meaningful name?



##########
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala:
##########
@@ -40,6 +40,7 @@ class WorkerInfo(
     val userResourceConsumption: util.Map[UserIdentifier, ResourceConsumption],
     var endpoint: RpcEndpointRef) extends Serializable with Logging {
   var unknownDiskSlots = new java.util.HashMap[String, Integer]()
+  var networkLocation = "/default-rack"

Review Comment:
   It is actually rack location. How about a clear and meaningful name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1194914430


##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -261,7 +261,7 @@ private[celeborn] class Master(
           userResourceConsumption,
           requestId))
 
-    case requestSlots @ RequestSlots(_, _, _, _, _, _, _) =>
+    case requestSlots @ RequestSlots(_, _, _, _, _, _, _, _) =>

Review Comment:
   > I wonder if requests from old clients can be matched or not. Here needs some verification.
   
   Will default be false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1547138572

   BTW, it may hurt performance if two replicas are on different racks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1194565549


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {

Review Comment:
   How about moving this class to master module? I found that our common module contains too much content.



##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -32,6 +32,8 @@ import org.apache.celeborn.common.util.CelebornHadoopUtils
 
 class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {
 
+  val enabledRackAware = celebornConf.slotsAssignRackAwareEnabled
+
   private val dnsToSwitchMapping: DNSToSwitchMapping = {
     val conf: Configuration = CelebornHadoopUtils.newConfiguration(celebornConf)

Review Comment:
   How about move CelebornHadoopUtils to master module? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#issuecomment-1547377328

   ping @FMX , could you take a look at this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org