You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by ep...@google.com on 2008/05/21 20:12:11 UTC
Re: svn commit: r31292 - trunk/subversion/bindings/javahl/native
markphip@tigris.org writes:
> Author: markphip
> Date: Sun May 18 13:13:33 2008
> New Revision: 31292
>
> Log:
> JavaHL: Followup to r23812. Add Windows SSL certificate
> trust provider support to JavaHL.
>
> [ in subversion/bindings/javahl/ ]
>
> * native/SVNClient.cpp
> (SVNClient::getContext): Use Windows SSL certificate
> trust provider.
>
> Modified:
> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>
> Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native
> /SVNClient.cpp?pathrev=31292&r1=31291&r2=31292
> =============================================================================
> =
> --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Sun May 18 12:4
> 0:54 2008 (r31291)
> +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Sun May 18 13:1
> 3:33 2008 (r31292)
> @@ -1219,6 +1219,10 @@ svn_client_ctx_t *SVNClient::getContext(
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>
> /* The server-cert, client-cert, and client-cert-password providers. */
> +#if defined(WIN32) && !defined(__MINGW32__)
> + svn_auth_get_windows_ssl_server_trust_provider(&provider, pool);
> + APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> +#endif
As far as I could tell when I first started building on Windows,
you can't build svn with mingw. I wish we could, and hope that
will one day change. So, why do you disable this in the mingw
case? I don't see how the tool chain has any impact on this.
When we can build with mingw, the resulting binaries should be
able to talk to the Windows trust store.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r31292 - trunk/subversion/bindings/javahl/native
Posted by ep...@google.com.
Mark Phippard <mp...@collab.net> writes:
> You would have to ask the original committer. I copied the code added to
> the command line in r23812 into JavaHL
Ah, OK. It originated with these:
------------------------------------------------------------------------
r22014 | rooneg | 2006-10-17 18:11:47 -0700 (Tue, 17 Oct 2006) | 5 lines
Fix typo from r22006 so we correctly use windows crypto on non-MinGW builds.
* subversion/libsvn_subr/cmdline.c
(svn_cmdline_setup_auth_baton): Actually ifdef correctly for MinGW.
------------------------------------------------------------------------
r22006 | rooneg | 2006-10-17 14:13:41 -0700 (Tue, 17 Oct 2006) | 28 lines
Disable the windows specific auth provider when building under MinGW
since it doesn't currently compile due to defficiencies in the MinGW
headers.
------------------------------------------------------------------------
Hopefully whatever the problem was is or will be gone by the time
someone fixes our mingw build :)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r31292 - trunk/subversion/bindings/javahl/native
Posted by Mark Phippard <mp...@collab.net>.
On 5/21/08 4:12 PM, "epg@google.com" <ep...@google.com> wrote:
> markphip@tigris.org writes:
>
>> Log:
>> JavaHL: Followup to r23812. Add Windows SSL certificate
>> trust provider support to JavaHL.
>>
>> [ in subversion/bindings/javahl/ ]
>>
>> * native/SVNClient.cpp
>> (SVNClient::getContext): Use Windows SSL certificate
>> trust provider.
>>
>> Modified:
>> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>>
>> Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native
>> /SVNClient.cpp?pathrev=31292&r1=31291&r2=31292
>> =============================================================================
>> =
>> --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Sun May 18 12:4
>> 0:54 2008 (r31291)
>> +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Sun May 18 13:1
>> 3:33 2008 (r31292)
>> @@ -1219,6 +1219,10 @@ svn_client_ctx_t *SVNClient::getContext(
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>>
>> /* The server-cert, client-cert, and client-cert-password providers. */
>> +#if defined(WIN32) && !defined(__MINGW32__)
>> + svn_auth_get_windows_ssl_server_trust_provider(&provider, pool);
>> + APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> +#endif
>
> As far as I could tell when I first started building on Windows,
> you can't build svn with mingw. I wish we could, and hope that
> will one day change. So, why do you disable this in the mingw
> case? I don't see how the tool chain has any impact on this.
> When we can build with mingw, the resulting binaries should be
> able to talk to the Windows trust store.
You would have to ask the original committer. I copied the code added to
the command line in r23812 into JavaHL
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org