You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/02/06 22:45:07 UTC
Review Request 30747: SQOOP-2086: Sqoop2: Use named constraints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30747/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2086
https://issues.apache.org/jira/browse/SQOOP-2086
Repository: sqoop-sqoop2
Description
-------
commit d76826fbb7a0b534fb3088ae2ae914eb55108d2a
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 6 13:41:24 2015 -0800
SQOOP-2086: Sqoop2: Use named constraints
:100644 100644 e645c7d... 50c98b7... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
:100644 100644 51d0bd6... c02ab48... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
Diffs
-----
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 51d0bd6
Diff: https://reviews.apache.org/r/30747/diff/
Testing
-------
postgresql tests are passing
Thanks,
Abraham Elmahrek
Re: Review Request 30747: SQOOP-2086: Sqoop2: Use named constraints
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Feb. 6, 2015, 9:50 p.m., Gwen Shapira wrote:
> > Please have a followup JIRA for re-using same constraint names for Derby and PG.
See https://issues.apache.org/jira/browse/SQOOP-1994
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30747/#review71508
-----------------------------------------------------------
On Feb. 6, 2015, 9:45 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30747/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 9:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2086
> https://issues.apache.org/jira/browse/SQOOP-2086
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d76826fbb7a0b534fb3088ae2ae914eb55108d2a
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 6 13:41:24 2015 -0800
>
> SQOOP-2086: Sqoop2: Use named constraints
>
> :100644 100644 e645c7d... 50c98b7... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
> :100644 100644 51d0bd6... c02ab48... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
>
>
> Diffs
> -----
>
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 51d0bd6
>
> Diff: https://reviews.apache.org/r/30747/diff/
>
>
> Testing
> -------
>
> postgresql tests are passing
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 30747: SQOOP-2086: Sqoop2: Use named constraints
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30747/#review71508
-----------------------------------------------------------
Ship it!
Please have a followup JIRA for re-using same constraint names for Derby and PG.
- Gwen Shapira
On Feb. 6, 2015, 9:45 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30747/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 9:45 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2086
> https://issues.apache.org/jira/browse/SQOOP-2086
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d76826fbb7a0b534fb3088ae2ae914eb55108d2a
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 6 13:41:24 2015 -0800
>
> SQOOP-2086: Sqoop2: Use named constraints
>
> :100644 100644 e645c7d... 50c98b7... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
> :100644 100644 51d0bd6... c02ab48... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
>
>
> Diffs
> -----
>
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java e645c7d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java 51d0bd6
>
> Diff: https://reviews.apache.org/r/30747/diff/
>
>
> Testing
> -------
>
> postgresql tests are passing
>
>
> Thanks,
>
> Abraham Elmahrek
>
>