You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2015/03/03 19:13:49 UTC

Review Request 31687: OOZIE-2160 Support attachment in email action

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/
-----------------------------------------------------------

Review request for oozie.


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2160


Diffs
-----

  client/src/main/resources/email-action-0.2.xsd 60ce545 
  core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
  core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
  docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 

Diff: https://reviews.apache.org/r/31687/diff/


Testing
-------

still in testing


Thanks,

Ryota Egashira

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75270
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment122244>

    Will this work for hdfs file? User will have file in hdfs.



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment122238>

    can be this done as new File(path).getName()


- Purshotam Shah


On March 3, 2015, 6:13 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 6:13 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> still in testing
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75495
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment122616>

    element.getChildTextTrim(ATTACHMENT, ns) -> attachment



core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment122617>

    You should not be allowing local file attachment. I can use that to fetch a password file on the Oozie server host and is a security risk.



docs/src/site/twiki/DG_EmailActionExtension.twiki
<https://reviews.apache.org/r/31687/#comment122618>

    [COMMA-SEPARATED-HDFS-FILE-PATHS]



docs/src/site/twiki/DG_EmailActionExtension.twiki
<https://reviews.apache.org/r/31687/#comment122619>

    Correction of plural usage
    
    The =attachment= is used to attach HDFS file(s) to the mail. Multiple attachments can be


- Rohini Palaniswamy


On March 5, 2015, 1:45 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 1:45 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

> On March 6, 2015, 6:26 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java, line 227
> > <https://reviews.apache.org/r/31687/diff/2/?file=885745#file885745line227>
> >
> >     You will have to do doAs as that user to access the hdfs file. Oozie user will not have permissions to read it.

URIDataSource is doing that


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75505
-----------------------------------------------------------


On March 7, 2015, 5:54 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 5:54 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75505
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment122628>

    You will have to do doAs as that user to access the hdfs file. Oozie user will not have permissions to read it.


- Rohini Palaniswamy


On March 5, 2015, 1:45 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 1:45 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75776
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On March 9, 2015, 8:45 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 8:45 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75778
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment123053>

    This should throw exception, so that email action can fail.



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment123051>

    This should throw exception, so that email action can fail.



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment123052>

    This should throw exception, so that email action can fail.


- Purshotam Shah


On March 9, 2015, 8:45 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 8:45 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/
-----------------------------------------------------------

(Updated March 10, 2015, 6:27 p.m.)


Review request for oozie.


Changes
-------

chagned it to error out.


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2160


Diffs (updated)
-----

  client/src/main/resources/email-action-0.2.xsd 60ce545 
  core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
  core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
  docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 

Diff: https://reviews.apache.org/r/31687/diff/


Testing
-------

test done. tested in QE enviornment with real HDFS


Thanks,

Ryota Egashira

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/
-----------------------------------------------------------

(Updated March 9, 2015, 8:45 p.m.)


Review request for oozie.


Changes
-------

final version with fix


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2160


Diffs (updated)
-----

  client/src/main/resources/email-action-0.2.xsd 60ce545 
  core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
  core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
  docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 

Diff: https://reviews.apache.org/r/31687/diff/


Testing
-------

test done. tested in QE enviornment with real HDFS


Thanks,

Ryota Egashira

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75764
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment123021>

    LOG.warn


- Rohini Palaniswamy


On March 7, 2015, 5:54 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 5:54 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/
-----------------------------------------------------------

(Updated March 7, 2015, 5:54 a.m.)


Review request for oozie.


Changes
-------

revised version


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2160


Diffs (updated)
-----

  client/src/main/resources/email-action-0.2.xsd 60ce545 
  core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
  core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
  docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 

Diff: https://reviews.apache.org/r/31687/diff/


Testing
-------

test done. tested in QE enviornment with real HDFS


Thanks,

Ryota Egashira

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.

> On March 6, 2015, 7:02 p.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java, line 148
> > <https://reviews.apache.org/r/31687/diff/2/?file=885745#file885745line148>
> >
> >     attachments can be parameterized, so we need to evaluate it.

ensure EL funct works on that


- Ryota


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75526
-----------------------------------------------------------


On March 7, 2015, 5:54 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 5:54 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/#review75526
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
<https://reviews.apache.org/r/31687/#comment122660>

    attachments can be parameterized, so we need to evaluate it.


- Purshotam Shah


On March 5, 2015, 1:45 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31687/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 1:45 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2160
> 
> 
> Diffs
> -----
> 
>   client/src/main/resources/email-action-0.2.xsd 60ce545 
>   core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
>   core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
>   core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
>   docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 
> 
> Diff: https://reviews.apache.org/r/31687/diff/
> 
> 
> Testing
> -------
> 
> test done. tested in QE enviornment with real HDFS
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/
-----------------------------------------------------------

(Updated March 5, 2015, 1:45 p.m.)


Review request for oozie.


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2160


Diffs
-----

  client/src/main/resources/email-action-0.2.xsd 60ce545 
  core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
  core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
  docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 

Diff: https://reviews.apache.org/r/31687/diff/


Testing (updated)
-------

test done. tested in QE enviornment with real HDFS


Thanks,

Ryota Egashira

Re: Review Request 31687: OOZIE-2160 Support attachment in email action

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31687/
-----------------------------------------------------------

(Updated March 5, 2015, 1:44 p.m.)


Review request for oozie.


Changes
-------

support attaching file on HDFS,  fixed review comment


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-2160


Diffs (updated)
-----

  client/src/main/resources/email-action-0.2.xsd 60ce545 
  core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java 21c6313 
  core/src/main/java/org/apache/oozie/service/AbandonedCoordCheckerService.java ec8cf71 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java e1f314e 
  docs/src/site/twiki/DG_EmailActionExtension.twiki 695e16b 

Diff: https://reviews.apache.org/r/31687/diff/


Testing
-------

still in testing


Thanks,

Ryota Egashira