[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #301: Upgrade to DF 21

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #301:
URL: https://github.com/apache/arrow-datafusion-python/pull/301#discussion_r1153459959


##########
datafusion/tests/test_dataframe.py:
##########
@@ -164,16 +164,17 @@ def test_join():
         [pa.array([1, 2, 3]), pa.array([4, 5, 6])],
         names=["a", "b"],
     )
-    df = ctx.create_dataframe([[batch]])
+    df = ctx.create_dataframe([[batch]], "l")

Review Comment:
   I had to alias these tables to fix an ambiguous column reference later in the test ... seems like an improvement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org