You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/23 07:17:07 UTC

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15637: Fix _copy_to on MKLDNN backend

ZhennanQin commented on a change in pull request #15637: Fix _copy_to on MKLDNN backend
URL: https://github.com/apache/incubator-mxnet/pull/15637#discussion_r306161158
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -419,7 +419,7 @@ inline void PushFCompute(const FCompute& fn,
       // mapping from index in input_blobs to index in pre_temp_dst
       std::unordered_map<uint32_t, uint32_t> in_temp_idx_map;
 #if MXNET_USE_MKLDNN == 1
-      InvalidateOutputs(outputs, req);
+      if (exec_type != ExecType::kCrossDeviceCopy) InvalidateOutputs(outputs, req);
 
 Review comment:
   Only for `kCrossDeviceCopy`, because `_copy_to` op is implemented with this, and it's quite strange. Not sure if I can explain this clearly in short. I'll try.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services