You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/08/07 14:32:48 UTC

[GitHub] flink issue #4470: [FLINK-7343] Simulate network failures in kafka at-least-...

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4470
  
    Yes I also didn't like adding this new flag, but didn't have enough motivation to change it. I have done some refactoring extracting those dynamically set in `prepare` method to some `Config` class. 
    
    However it helps only a little bit. Those tests would need a more comprehensive refactor in the future. I particularly don't like that this `prepare` method exists, it should all be configured in the constructor and all of those should be final fields.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---