You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ni...@apache.org on 2022/02/06 17:58:23 UTC
[cordova-osx] 04/04: fix lint errors manually
This is an automated email from the ASF dual-hosted git repository.
niklasmerz pushed a commit to branch prepare-7.0.0
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git
commit 65d8badf0345a7983cb6c081254412891225d1f2
Author: Niklas Merz <ni...@apache.org>
AuthorDate: Sun Feb 6 18:44:14 2022 +0100
fix lint errors manually
---
bin/templates/scripts/cordova/lib/build.js | 19 -------------------
cordova-js-src/exec.js | 11 +++++------
2 files changed, 5 insertions(+), 25 deletions(-)
diff --git a/bin/templates/scripts/cordova/lib/build.js b/bin/templates/scripts/cordova/lib/build.js
index e438376..afbfe40 100644
--- a/bin/templates/scripts/cordova/lib/build.js
+++ b/bin/templates/scripts/cordova/lib/build.js
@@ -81,25 +81,6 @@ module.exports.run = function (buildOpts) {
const xcodebuildArgs = getXcodeArgs(projectName, projectPath, configuration);
return spawn('xcodebuild', xcodebuildArgs, projectPath);
- }).then(function () {
- if (buildOpts.noSign) {
-
- }
- // var buildOutputDir = path.join(projectPath, 'build');
- // var pathToApp = path.join(buildOutputDir, projectName + '.app');
- // var pathToIpa = path.join(buildOutputDir, projectName + '.ipa');
- // var xcRunArgs = ['-sdk', 'iphoneos', 'PackageApplication',
- // '-v', pathToApp,
- // '-o', pathToIpa];
- // if (buildOpts.codeSignIdentity) {
- // xcRunArgs.concat('--sign', buildOpts.codeSignIdentity);
- // }
- // if (buildOpts.provisioningProfile) {
- // xcRunArgs.concat('--embed', buildOpts.provisioningProfile);
- // }
- // return spawn('xcrun', xcRunArgs, projectPath);
-
- // todo
});
};
diff --git a/cordova-js-src/exec.js b/cordova-js-src/exec.js
index 494d213..0965057 100644
--- a/cordova-js-src/exec.js
+++ b/cordova-js-src/exec.js
@@ -78,14 +78,13 @@ function massageArgsJsToNative (args) {
}
function OSXExec () {
- let successCallback, failCallback, service, action, actionArgs;
let callbackId = 'INVALID';
- successCallback = arguments[0];
- failCallback = arguments[1];
- service = arguments[2];
- action = arguments[3];
- actionArgs = arguments[4];
+ const successCallback = arguments[0];
+ const failCallback = arguments[1];
+ const service = arguments[2];
+ const action = arguments[3];
+ let actionArgs = arguments[4];
// Register the callbacks and add the callbackId to the positional
// arguments if given.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org