[GitHub] [spark] AngersZhuuuu removed a comment on pull request #33873: [SPARK-36624][YARN] In yarn client mode, when ApplicationMaster failed with KILLED/FAILED, driver should exit with code not 0

[GitBox <gi...@apache.org>]

AngersZhuuuu removed a comment on pull request #33873:
URL: https://github.com/apache/spark/pull/33873#issuecomment-912895370


   > A callback sounds find to me.
   > @AngersZhuuuu doesn't a callback require user code changes, which he has said is hard for him?
   
   Not so sure about what you mean, you mean user feel hard to write a call back?
   
   Add a callback can solve some case,  you mean  we can add a callback in YarnClientSchedulerBackend.MonitorThread's `sc.stop()`.
   
   Such as add a Shutdown hook to the callback, if the program ended and the status is failed and killed, we call this shutdown hook to exit with code 1? @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org