You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "sbp (via GitHub)" <gi...@apache.org> on 2025/10/21 13:16:24 UTC

[I] Add a list of all file checks to the documentation (tooling-trusted-releases)

sbp opened a new issue, #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254

   We could also add a section about how to contribute checks. Such checks might be scoped towards an individual project, and could be opt-in, turned off by default. We don't want to accumulate too many special cases, but for auditability etc. it wouldn't be a good idea to allow external check calls.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3438379596

   @sbp I see lots of places where checking happens but which file checks is this referring to and where would I find that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3443420152

   Resolved by 4403d940ea4e33275ee6ac6a2eaaa4fd5c982ea3, 5621af7823720acb3a0fe1b0f3d08d544b61fd92, 1a3832660981ef719be332b296cf93aead762856, and 1a3832660981ef719be332b296cf93aead762856. Many thanks to @andrewmusselman for the contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3439379609

   @sbp would we want a new page for this in `docs` linked to from the `developer-guide.md`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3439800181

   @andrewmusselman I've been pondering that too, and I don't know whether it should be a new page or whether it should be part of an existing page. I think I'd have to see it _in situ_ to decide.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3440682162

   @sbp I'll write something and propose it in a PR, the existing pages are self-contained, and "how to contribute" is the standard code contribution doc so maybe a new page is cleaner; or, 3.9.* become individual "contrib" type guidelines


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #254: Add a list of all file checks to the documentation
URL: https://github.com/apache/tooling-trusted-releases/issues/254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3440853498

   @sbp it's unclear to me how much would need to be added for an arbitrary task, for example, `atr/tasks/__init__.py` has some bundled task lists defined for tarballs and zip files, and signature files have a `sha_checks` function defined. I'll make a PR, let me know if it's sufficient for this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "andrewmusselman (via GitHub)" <gi...@apache.org>.
andrewmusselman commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3443641210

   Thanks @sbp, glad it helped


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Add a list of all file checks to the documentation (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #254:
URL: https://github.com/apache/tooling-trusted-releases/issues/254#issuecomment-3438954914

   @andrewmusselman Basically everything in `atr/tasks/checks/`. Unfortunately it's not really possible to tell from [`atr/tasks/__init__.py`](https://github.com/apache/tooling-trusted-releases/blob/main/atr/tasks/__init__.py) what the individual functions are with ease, but a little analysis will reveal this: anything imported from `import atr.tasks.checks[.*]` and then used in the `resolve` function is a check that the ATR can perform. (This is why it needs documenting. But we also should have a way to make this easier to identify, so that we can more easily update the documentation.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org