You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 11:52:43 UTC

[GitHub] [arrow] alamb commented on pull request #8867: ARROW-10842 [Rust] decouple IO from json reader

alamb commented on pull request #8867:
URL: https://github.com/apache/arrow/pull/8867#issuecomment-741723145


   @houqp  it seems as though there are some clippy errors that are preventing a clean test run: https://github.com/apache/arrow/pull/8867/checks?check_run_id=1522963773
   
   
   ```
    Compiling arrow v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/arrow)
   error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
      --> arrow/src/json/reader.rs:546:5
       |
   546 | /     pub fn next_batch<'a, 'b, I>(
   547 | |         &'a self,
   548 | |         value_iter: &'b mut I,
   549 | |     ) -> Result<Option<RecordBatch>>
       | |____________________________________^
       |
       = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   
   error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
      --> arrow/src/json/reader.rs:546:5
       |
   546 | /     pub fn next_batch<'a, 'b, I>(
   547 | |         &'a self,
   548 | |         value_iter: &'b mut I,
   549 | |     ) -> Result<Option<RecordBatch>>
       | |____________________________________^
       |
       = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   
   error: aborting due to previous error
   
   error: could not compile `arrow`
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org