You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andrew Lamb (Jira)" <ji...@apache.org> on 2021/03/19 10:37:00 UTC

[jira] [Created] (ARROW-12024) [Rust] Rust 1.52 has additional clippy lint failure

Andrew Lamb created ARROW-12024:
-----------------------------------

             Summary: [Rust] Rust 1.52 has additional clippy lint failure
                 Key: ARROW-12024
                 URL: https://issues.apache.org/jira/browse/ARROW-12024
             Project: Apache Arrow
          Issue Type: Bug
            Reporter: Andrew Lamb
            Assignee: Andrew Lamb


Rust 1.52 was released yesterday:

info: latest update on 2021-03-19, rust version 1.52.0-nightly (1705a7d64 2021-03-18)

Resulting in lint failures such as
https://github.com/apache/arrow/pull/9749/checks?check_run_id=2144048180

{code}
error: this `else { if .. }` block can be collapsed
   --> arrow/src/array/array_binary.rs:427:20
    |
427 |               } else {
    |  ____________________^
428 | |                 if let Some(size) = size {
429 | |                     buffer.extend_zeros(size);
430 | |                 } else {
431 | |                     prepend += 1;
432 | |                 }
433 | |             }
    | |_____________^
    |
    = note: `-D clippy::collapsible-if` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
help: collapse nested if block
    |
427 |             } else if let Some(size) = size {
428 |                 buffer.extend_zeros(size);
429 |             } else {
430 |                 prepend += 1;
431 |             }
    |
{code}

Reproduce via running `rustup`



--
This message was sent by Atlassian Jira
(v8.3.4#803005)