Re: Review Request 22526: WIP:Added resizeTask primitive.

[Yifan Gu <yi...@mesosphere.io>]

> On June 19, 2014, 7:42 a.m., Adam B wrote:
> > include/mesos/mesos.proto, lines 527-528
> > <https://reviews.apache.org/r/22526/diff/11/?file=611738#file611738line527>
> >
> >     Why do you need both old & new resources? In case multiple resize tasks come through at a time, or to handle resource changes during slave failovers or other tasks starting/completing?

Yes, when a master fails over, or multiple resize tasks come through. the master may not be able to remember if a task is to be scaled up or down.
Any better solutions?


> On June 19, 2014, 7:42 a.m., Adam B wrote:
> > include/mesos/scheduler/scheduler.proto, lines 183-186
> > <https://reviews.apache.org/r/22526/diff/11/?file=611740#file611740line183>
> >
> >     Where did '2' go?
> 
> Yifan Gu wrote:
>     somewhere..

This was a typo


> On June 19, 2014, 7:42 a.m., Adam B wrote:
> > src/scheduler/scheduler.cpp, line 371
> > <https://reviews.apache.org/r/22526/diff/11/?file=611747#file611747line371>
> >
> >     send(master.get(), message); ?
> 
> Yifan Gu wrote:
>     lol..

need to add the missing piece: send message back to master.


- Yifan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22526/#review46192
-----------------------------------------------------------


On June 17, 2014, 6:23 p.m., Yifan Gu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22526/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 6:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-1279
>     https://issues.apache.org/jira/browse/MESOS-1279
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added resizeTask primitive.
> 
> This is just a proof of concept now. I will work on the unit test.
> Currently I added one state called "TASK_RESIZE" in state update, so that the master/framework can get the resize result from the slave.
> I put the result in the 'data' field of the TaskStatus.
> 
> And I feel that I copy-pasted a lot of checkers, which is kind mess, I think they should be put into a separate module later.
> 
> Any question or suggestion is highly welcome! Thanks!
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 102289b 
>   include/mesos/scheduler.hpp d224945 
>   include/mesos/scheduler/scheduler.proto 6ab5089 
>   src/Makefile.am c91b438 
>   src/common/protobuf_utils.hpp 12ff00a 
>   src/master/master.hpp 7a12185 
>   src/master/master.cpp 4a01b1a 
>   src/messages/messages.proto 8aecc8b 
>   src/sched/sched.cpp 6e14f1c 
>   src/scheduler/scheduler.cpp 4ae188e 
>   src/slave/slave.hpp 34687e5 
>   src/slave/slave.cpp 643c088 
>   src/tests/resize_task_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22526/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>