You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/12/01 03:30:33 UTC
Re: Review Request 73049: ATLAS-4044: Atlas import-kafka.sh does not
import "__consumer_offsets" topic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73049/#review222256
-----------------------------------------------------------
Please update the JIRA referenced in this review; it should be ATLAS-4043.
common/src/main/java/org/apache/atlas/utils/KafkaUtils.java
Line 109 (original), 104 (patched)
<https://reviews.apache.org/r/73049/#comment311324>
Tracking Kafka's internal topics in Atlas may not be useful. I suggest to introduce a config to control whether to import internal topics or not.
atlas.hook.kafka.import.internal.topics
The default should be false; deployments that need to track internal topics can set this configuration to true in atlas-application.properties.
- Madhan Neethiraj
On Nov. 30, 2020, 7:06 p.m., Deep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73049/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2020, 7:06 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4044
> https://issues.apache.org/jira/browse/ATLAS-4044
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Recently changes were made to remove dependency on zookeeper. This bug got introduced as regression. Kafka AdminClient is now used to get the list of existing topics. The API removes the topic which are internal to Kafka.
> With this fix I have introduced an API option to include the internal topic as well.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/utils/KafkaUtils.java 7a397b19b
>
>
> Diff: https://reviews.apache.org/r/73049/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Deep Singh
>
>