You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/11/18 13:35:42 UTC
[GitHub] [james-project] jeantil opened a new pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
jeantil opened a new pull request #263:
URL: https://github.com/apache/james-project/pull/263
This PR adds systematic enforcement of the ordering of pom dependencies and modules. The sorting engine when rewriting a pom also enforces top level tag ordering and tag ordering within the parent tag as they appear in the maven project descriptor (pom xsd).
After applying this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526244131
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
I will make the change.
However I would like to point out https://maven.apache.org/guides/mini/guide-naming-conventions.html
> groupId uniquely identifies your project across all projects. [...] That is, if the current project is a multiple module project, it should append a new identifier to the parent's groupId.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526185588
##########
File path: server/queue/queue-activemq/pom.xml
##########
@@ -35,9 +35,11 @@
<dependencies>
<!-- Forcing netty-transport version -->
<dependency>
+ <?SORTPOM IGNORE?>
Review comment:
exactly this is one of the few cases where dependency declaration order is important more information at https://github.com/Ekryd/sortpom/wiki/Parameters-that-can-affect-your-build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730193158
>Can you have a look? Is that an auto generated file? Can we ignore it?
I'll look into this a quick run of mvn validate didn't fail but running the `docker run` based compilation from the readme did fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526171502
##########
File path: server/queue/queue-activemq/pom.xml
##########
@@ -35,9 +35,11 @@
<dependencies>
<!-- Forcing netty-transport version -->
<dependency>
+ <?SORTPOM IGNORE?>
Review comment:
Prevent a reordering causing netty override to be lost i guess
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-731084175
I squash the fixups unpo merges, and I also added a missing `JAMES-2124` prefix.
Overwize, I keep the history presented during the review, as you produced nice separated unitary commits ;-)
Does this answer some of your questions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526228136
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##########
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Review comment:
no problem as far as it is not mandatory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526153685
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##########
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Review comment:
is this white space change mandatory?
##########
File path: server/queue/queue-activemq/pom.xml
##########
@@ -35,9 +35,11 @@
<dependencies>
<!-- Forcing netty-transport version -->
<dependency>
+ <?SORTPOM IGNORE?>
Review comment:
why?
##########
File path: server/pom.xml
##########
@@ -70,9 +70,9 @@
<module>dns-service/dnsservice-library</module>
<module>dns-service/dnsservice-test</module>
- <module>mailet/integration-testing</module>
-
<module>mailet/dkim</module>
+
Review comment:
this blank line does not make sense now
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
this one is trickier because it's not really an internal POM. Maybe we should replace ${james.groupId} by org.apache.james here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526184899
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
I don't understand : how can it not be internal if it is under our groupId ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-731079567
aweswome, I was unsure if I could to squash the commits to clean up the PR as it would reduce readability for review followup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526227740
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
mime4j is a project of org.apache.james. But it's not in the same repository and has not the same versioning than James.
That's why I think here we should explicit "org.apache.james".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730104626
```
The fastest way to test this is to use
mvn package -DskipTests //will fail if a pom contains violations
//or
mvn package -DskipTests -PsortPom // will rewrite all the poms which contain violations
....
```
This fit the https://github.com/apache/james-project/blob/master/src/site/xdoc/contribute.xml https://github.com/apache/james-project/blob/master/docs/modules/community/pages/contributing.adoc content.
Can you add that there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730259675
@chibenwa I have updated the documentatiom. I also moved POM validation to the `validate` phase ( before compile ) so it can be executed very quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526187087
##########
File path: server/pom.xml
##########
@@ -70,9 +70,9 @@
<module>dns-service/dnsservice-library</module>
<module>dns-service/dnsservice-test</module>
- <module>mailet/integration-testing</module>
-
<module>mailet/dkim</module>
+
Review comment:
fixedup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730229970
@chibenwa I don't know how I missed it but the latest fixup should fix the issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-731076659
I merged this work quickly in order to limit conflicts, and prevent rebases here.
If there are some other feedback, we can handle it afterward.
Cheers, and thanks for this nice contribution!
Benoit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526184190
##########
File path: server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##########
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0"
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Review comment:
it's not mandatory but because whitespace is considered non-significant in the XML specification parsers don't keep position information in many cases this is one of them. Since
- there were few pom affected by the whitespace removal
- this will prevent spurious modifications that humans will have to think about
- the namespace declaration on the project tag are more or less noise to humans
I added the few normalizations to the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-729919156
I added 4 commits to address the comments and improve the PR a bit
- 073b33c drops the incorrect blank line in server/pom.xml
- bcd0a26 switches to using explicit groupIds for apache-mime4j dependencies
- 7a062c3 reverts incorrectly changed empty tags
- defb95b switches pom validation and sorting from compile to earlier validate phase, meaning the build will fail even earlier and running `mvn validate -PsortPom` lets developpers fix poms in a few seconds instead of a several minutes compilation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-731087022
It was more an apology for letting you do the fixup work than a question :) I had no doubts the history would be preserved ( so little doubts that I didn't event check !)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] rouazana commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526299932
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
I guess it's historical. Probably we should rename mime4j's group id now, but it's not a trivial change :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil closed pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil closed pull request #263:
URL: https://github.com/apache/james-project/pull/263
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526568200
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
> Probably we should rename mime4j's group id now
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526376965
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
I have added a commit which explicitely drops the `${james.groupId}` for all the `apache-mime4j-xxx` artifacts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #263: JAMES-2124 Enforces pom modules and dependencies ordering
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-730106818
Compiling locally:
```
[ERROR] Failed to execute goal com.github.ekryd.sortpom:sortpom-maven-plugin:2.12.0:verify (strict-pom-ordering) on project apache-james-mpt-app: The file /home/benwa/Documents/apache/james-project/mpt/app/dependency-reduced-pom.xml is not sorted -> [Help 1]
```
Can you have a look? Is that an auto generated file? Can we ignore it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org