You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2018/02/27 23:08:57 UTC
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198351
-----------------------------------------------------------
PASS: Mesos patch 63862 was successfully built and tested.
Reviews applied: `['63862']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
- Mesos Reviewbot Windows
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/6/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>