You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/12 14:01:31 UTC
[GitHub] [incubator-mxnet] TaoLv opened a new pull request #18033: [v1.x]
Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
TaoLv opened a new pull request #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033
* update onednn remote url
* checkout onednn v1.3 release
* fix format test
* make test
Conflicts:
.gitmodules
3rdparty/mkldnn
tests/cpp/operator/mkldnn_test.cc
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] TaoLv edited a comment on issue #18033: [v1.x]
Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
TaoLv edited a comment on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-612619503
cc @ciyongch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #18033: [v1.x] Update
3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
TaoLv commented on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-613796536
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18033: [v1.x]
Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-612619360
Hey @TaoLv , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, website, windows-gpu, windows-cpu, unix-cpu, edge, centos-cpu, centos-gpu, clang, sanity, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #18033: [v1.x] Update
3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
TaoLv commented on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-612619503
cc @ciyong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18033: [v1.x]
Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-613796558
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] TaoLv commented on issue #18033: [v1.x] Update
3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
TaoLv commented on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-613797590
@leezu I borrowed the cmake upgrade code from #17645 as the new DNNL library needs higher version of cmake than the one in v1.x CI. Please let me know if you have any concern. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] pengzhao-intel merged pull request #18033: [v1.x]
Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
pengzhao-intel merged pull request #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ciyongch commented on issue #18033: [v1.x] Update
3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18033: [v1.x] Update 3rdparty/mkldnn remote URL and pin to v1.3 (#17972)
URL: https://github.com/apache/incubator-mxnet/pull/18033#issuecomment-613797572
Adding this to v1.7.0 roadmap https://github.com/apache/incubator-mxnet/issues/16864
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services