You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/21 18:30:12 UTC

[GitHub] [beam] egalpin commented on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

egalpin commented on pull request #16309:
URL: https://github.com/apache/beam/pull/16309#issuecomment-999002295


   Thanks very much @khersey, great catch.  This didn't previously get caught by tests because it only surfaces in cases where `ElasticsearchIO#bulkIO` is called on its own and not as part of calling `ElasticsearchIO#write`.
   
   @khersey Could you please add a test like `ElasticsearchIOTestCommon#testWrite` but chaining together `ElasticsearchIO#docToBulk` and `ElasticsearchIO#bulkIO` separately?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org