You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jonathanc-n (via GitHub)" <gi...@apache.org> on 2026/02/05 21:18:56 UTC

Re: [PR] feat: Add Semi/Anti join to PiecewiseMergeJoin [datafusion]

jonathanc-n commented on code in PR #18392:
URL: https://github.com/apache/datafusion/pull/18392#discussion_r2771202164


##########
datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs:
##########
@@ -462,9 +446,35 @@ impl PiecewiseMergeJoinExec {
         }
     }
 
-    // TODO
+    // Inner, Outer, Left, Right joins are swapped so that left side is larger than right
+    // Left Semi/Anti joins are not swapped while Right Semi/Anti joins are always swapped. This

Review Comment:
   I'm going to include the comment in both places, just so anybody who reads either function will understand the logic. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org