[GitHub] [flink] wuchong commented on a change in pull request #10823: [FLINK-15497][table-planner-blink] Reduce outputs when rank number is not required in Retractable topN

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #10823: [FLINK-15497][table-planner-blink] Reduce outputs when rank number is not required in Retractable topN
URL: https://github.com/apache/flink/pull/10823#discussion_r365800715
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/RankITCase.scala
 ##########
 @@ -1311,4 +1311,49 @@ class RankITCase(mode: StateBackendMode) extends StreamingWithStateTestBase(mode
     assertEquals(expected2.sorted, sink2.getRetractResults.sorted)
   }
 
+  @Test
+  def testRetractRank(): Unit = {
 
 Review comment:
   Could you use `testTopNWithGroupByAvgWithoutRowNumber` to verify this which already have a meaningful testing data? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services