You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kanzhe Jiang <ka...@bigswitch.com> on 2013/01/29 06:59:31 UTC
Review Request: BigSwitch VNS Networking Plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
Diffs
-----
api/src/com/cloud/api/ApiConstants.java 78a3ded
api/src/com/cloud/event/EventTypes.java e69e4a4
api/src/com/cloud/network/Network.java d38f740
api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
build/build-cloud-plugins.xml 207ef71
build/developer.xml fdda171
client/pom.xml 1673429
client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
client/tomcatconf/components.xml.in 5957b61
cloud.spec 9f46dd6
debian/cloud-server.install 9cd1eeb
docs/en-US/Release_Notes.xml c8cc686
plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
plugins/pom.xml 2009302
server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
setup/db/create-schema.sql fff084e
tools/apidoc/gen_toc.py eeaf2a2
tools/apidoc/pom.xml b75ee82
wscript_configure 3b9377b
Diff: https://reviews.apache.org/r/9131/diff/
Testing
-------
Verify the builds: mvn clean install;
The database can be deployed;
CloudStack can be launched with the plugin modules.
JUnit tests of all api commands to a mock controller.
Thanks,
Kanzhe Jiang
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > api/src/com/cloud/api/ApiConstants.java, line 386
> > <https://reviews.apache.org/r/9131/diff/1/?file=252824#file252824line386>
> >
> > There is no reason to add your constant here. You can add it in your own plugin package
Moved to plugin.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > api/src/com/cloud/event/EventTypes.java, line 298
> > <https://reviews.apache.org/r/9131/diff/1/?file=252825#file252825line298>
> >
> > You can add your event types inside your own plugin
Moved to plugin.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > api/src/com/cloud/network/Network.java, line 126
> > <https://reviews.apache.org/r/9131/diff/1/?file=252826#file252826line126>
> >
> > You can add this in your own class in your plugin
Moved to plugin.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > api/src/com/cloud/network/PhysicalNetwork.java, line 36
> > <https://reviews.apache.org/r/9131/diff/1/?file=252827#file252827line36>
> >
> > What is this VNS method? Is the VNS an isolation technology? What is the RFC for this?
VNS is the isolation method implemented by the BigSwitch controller. In this release, it is a vlan-based isolation. In the future, I plan to add switch/port based isolation.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > build/build-cloud-plugins.xml, line 316
> > <https://reviews.apache.org/r/9131/diff/1/?file=252828#file252828line316>
> >
> > ant is not required
Removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > build/developer.xml, line 408
> > <https://reviews.apache.org/r/9131/diff/1/?file=252829#file252829line408>
> >
> > ant is deprecated/unsupported so this is unnecessary
Removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252837#file252837line1>
> >
> > this can be in project cloud-api/com.cloud.agent.api as it is likely to be useful to others. if not, then it should be CreateBVSNetworkAnswer
Renamed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252838#file252838line1>
> >
> > Rename to CreateBvsNetworkCommand?
Renamed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252839#file252839line1>
> >
> > Rename?
Renamed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252840#file252840line1>
> >
> > Rename?
Renamed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252843#file252843line1>
> >
> > Rename?
Renamed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252844#file252844line1>
> >
> > Rename?
Renamed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java, line 48
> > <https://reviews.apache.org/r/9131/diff/1/?file=252848#file252848line48>
> >
> > IdentityMapper is deprecated
Removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java, line 47
> > <https://reviews.apache.org/r/9131/diff/1/?file=252849#file252849line47>
> >
> > IdentityMapper is deprecated with the new api refactoring
Removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java, line 50
> > <https://reviews.apache.org/r/9131/diff/1/?file=252850#file252850line50>
> >
> > IdentityMapper
Removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java, line 22
> > <https://reviews.apache.org/r/9131/diff/1/?file=252853#file252853line22>
> >
> > What is an attachment?
> > File has tabs
Attachment contains portUUID and MAC address of the VM. It is used to classify VM into the correct virtual network.
Tab has been removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java, line 1
> > <https://reviews.apache.org/r/9131/diff/1/?file=252854#file252854line1>
> >
> > File has tabs instead of spaces
Tab has been removed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java, lines 172-173
> > <https://reviews.apache.org/r/9131/diff/1/?file=252854#file252854line172>
> >
> > These 2 are duplicated. Should be made constants?
> > Also suggest org.apache.cloudstack instead of CloudStack
Fixed.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java, line 299
> > <https://reviews.apache.org/r/9131/diff/1/?file=252854#file252854line299>
> >
> > How about a finally() { method.releaseConnection()} ?
No, releaseConnection can't be called if no HTTP or IO exception is caught since the responseBody needs to be retrieved later.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java, line 19
> > <https://reviews.apache.org/r/9131/diff/1/?file=252857#file252857line19>
> >
> > Name clash with CloudStack's Network. Should be BvSNetwork?
> > File has tabs
Renamed and removed tabs.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java, line 18
> > <https://reviews.apache.org/r/9131/diff/1/?file=252858#file252858line18>
> >
> > Name clash?
Renamed
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java, line 114
> > <https://reviews.apache.org/r/9131/diff/1/?file=252861#file252861line114>
> >
> > Shouldn't need a reference to the NetworkManager. Perhaps you want NetworkModel?
NetworkManager is used to check if it is the right provider. Didn't find NetworkModel.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java, line 323
> > <https://reviews.apache.org/r/9131/diff/1/?file=252861#file252861line323>
> >
> > tabs.
> > Are you sure the BVS can handle these?
Removed tabs. Fixed the capability.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > server/src/com/cloud/network/ExternalNetworkDeviceManager.java, line 44
> > <https://reviews.apache.org/r/9131/diff/1/?file=252868#file252868line44>
> >
> > This can be inside the plugin code
Moved to plugin.
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java, line 283
> > <https://reviews.apache.org/r/9131/diff/1/?file=252861#file252861line283>
> >
> > Should you not be destroying the network here?
The virtual network is destroyed when BigSwitchVnsGuestNetworkGuru.shutdown() is called.
When is NetworkElement.shutdown() is called?
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java, line 169
> > <https://reviews.apache.org/r/9131/diff/1/?file=252861#file252861line169>
> >
> > Empty?
The attachment point of the VM cloud be created when either NetworkElement.prepare() or NetworkElement().implement() is called.
I chose to create the network in prepare().
> On Jan. 29, 2013, 10:19 p.m., Chiradeep Vittal wrote:
> > plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java, line 23
> > <https://reviews.apache.org/r/9131/diff/1/?file=252851#file252851line23>
> >
> > Requires an annotation referring to the table
Please help. I am not sure what annotation you are referring to.
- Kanzhe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15807
-----------------------------------------------------------
On Jan. 29, 2013, 5:59 a.m., Kanzhe Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 5:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/ApiConstants.java 78a3ded
> api/src/com/cloud/event/EventTypes.java e69e4a4
> api/src/com/cloud/network/Network.java d38f740
> api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
> build/build-cloud-plugins.xml 207ef71
> build/developer.xml fdda171
> client/pom.xml 1673429
> client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
> client/tomcatconf/components.xml.in 5957b61
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
> plugins/pom.xml 2009302
> server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
> setup/db/create-schema.sql fff084e
> tools/apidoc/gen_toc.py eeaf2a2
> tools/apidoc/pom.xml b75ee82
> wscript_configure 3b9377b
>
> Diff: https://reviews.apache.org/r/9131/diff/
>
>
> Testing
> -------
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Thanks,
>
> Kanzhe Jiang
>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15807
-----------------------------------------------------------
api/src/com/cloud/api/ApiConstants.java
<https://reviews.apache.org/r/9131/#comment34029>
There is no reason to add your constant here. You can add it in your own plugin package
api/src/com/cloud/event/EventTypes.java
<https://reviews.apache.org/r/9131/#comment34030>
You can add your event types inside your own plugin
api/src/com/cloud/network/Network.java
<https://reviews.apache.org/r/9131/#comment34031>
You can add this in your own class in your plugin
api/src/com/cloud/network/PhysicalNetwork.java
<https://reviews.apache.org/r/9131/#comment34032>
What is this VNS method? Is the VNS an isolation technology? What is the RFC for this?
build/build-cloud-plugins.xml
<https://reviews.apache.org/r/9131/#comment34034>
ant is not required
build/developer.xml
<https://reviews.apache.org/r/9131/#comment34033>
ant is deprecated/unsupported so this is unnecessary
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java
<https://reviews.apache.org/r/9131/#comment34035>
this can be in project cloud-api/com.cloud.agent.api as it is likely to be useful to others. if not, then it should be CreateBVSNetworkAnswer
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java
<https://reviews.apache.org/r/9131/#comment34037>
Rename to CreateBvsNetworkCommand?
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java
<https://reviews.apache.org/r/9131/#comment34038>
Rename?
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java
<https://reviews.apache.org/r/9131/#comment34039>
Rename?
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java
<https://reviews.apache.org/r/9131/#comment34041>
Rename?
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java
<https://reviews.apache.org/r/9131/#comment34040>
Rename?
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java
<https://reviews.apache.org/r/9131/#comment34043>
IdentityMapper is deprecated
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java
<https://reviews.apache.org/r/9131/#comment34042>
IdentityMapper is deprecated with the new api refactoring
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java
<https://reviews.apache.org/r/9131/#comment34044>
IdentityMapper
plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java
<https://reviews.apache.org/r/9131/#comment34045>
Requires an annotation referring to the table
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java
<https://reviews.apache.org/r/9131/#comment34047>
What is an attachment?
File has tabs
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
<https://reviews.apache.org/r/9131/#comment34046>
File has tabs instead of spaces
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
<https://reviews.apache.org/r/9131/#comment34048>
These 2 are duplicated. Should be made constants?
Also suggest org.apache.cloudstack instead of CloudStack
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
<https://reviews.apache.org/r/9131/#comment34051>
How about a finally() { method.releaseConnection()} ?
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java
<https://reviews.apache.org/r/9131/#comment34054>
Name clash with CloudStack's Network. Should be BvSNetwork?
File has tabs
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java
<https://reviews.apache.org/r/9131/#comment34055>
Name clash?
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
<https://reviews.apache.org/r/9131/#comment34057>
Shouldn't need a reference to the NetworkManager. Perhaps you want NetworkModel?
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
<https://reviews.apache.org/r/9131/#comment34058>
Empty?
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
<https://reviews.apache.org/r/9131/#comment34059>
Should you not be destroying the network here?
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
<https://reviews.apache.org/r/9131/#comment34060>
tabs.
Are you sure the BVS can handle these?
server/src/com/cloud/network/ExternalNetworkDeviceManager.java
<https://reviews.apache.org/r/9131/#comment34061>
This can be inside the plugin code
- Chiradeep Vittal
On Jan. 29, 2013, 5:59 a.m., Kanzhe Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 5:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/ApiConstants.java 78a3ded
> api/src/com/cloud/event/EventTypes.java e69e4a4
> api/src/com/cloud/network/Network.java d38f740
> api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
> build/build-cloud-plugins.xml 207ef71
> build/developer.xml fdda171
> client/pom.xml 1673429
> client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
> client/tomcatconf/components.xml.in 5957b61
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
> plugins/pom.xml 2009302
> server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
> setup/db/create-schema.sql fff084e
> tools/apidoc/gen_toc.py eeaf2a2
> tools/apidoc/pom.xml b75ee82
> wscript_configure 3b9377b
>
> Diff: https://reviews.apache.org/r/9131/diff/
>
>
> Testing
> -------
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Thanks,
>
> Kanzhe Jiang
>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15793
-----------------------------------------------------------
Hey, The patch looks pretty familiar ;-) Can you explain a bit more about the current status of this patch? What is the current implemented functionality, is this code able to create a L2 network on a bigswitch controller?
Mainly i think it would be nice to include somekind of details on how to setup this plugin together with a bigswitch controller. I would like to be able to test the functionality of this patch.
I have a few questions regarding the reuse of the broadcast type lswitch and the L3 functionality that is still adverstised, but i will hold off until i get a chance to test this.
- Hugo Trippaers
On Jan. 29, 2013, 5:59 a.m., Kanzhe Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 5:59 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/ApiConstants.java 78a3ded
> api/src/com/cloud/event/EventTypes.java e69e4a4
> api/src/com/cloud/network/Network.java d38f740
> api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
> build/build-cloud-plugins.xml 207ef71
> build/developer.xml fdda171
> client/pom.xml 1673429
> client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
> client/tomcatconf/components.xml.in 5957b61
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
> plugins/pom.xml 2009302
> server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
> setup/db/create-schema.sql fff084e
> tools/apidoc/gen_toc.py eeaf2a2
> tools/apidoc/pom.xml b75ee82
> wscript_configure 3b9377b
>
> Diff: https://reviews.apache.org/r/9131/diff/
>
>
> Testing
> -------
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Thanks,
>
> Kanzhe Jiang
>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15991
-----------------------------------------------------------
committed to master with 736b236
- Prasanna Santhanam
On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 1:03 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/PhysicalNetwork.java a495092
> client/pom.xml 7ebe50c
> client/tomcatconf/commands.properties.in 755a5f2
> client/tomcatconf/components.xml.in c41d4f4
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8
> plugins/pom.xml c5b6e58
> setup/db/create-schema.sql ead98a5
> tools/apidoc/gen_toc.py 7739aea
> ui/scripts/ui-custom/zoneWizard.js ef606e9
> wscript_configure 3b9377b
>
> Diff: https://reviews.apache.org/r/9131/diff/
>
>
> Testing
> -------
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Thanks,
>
> Kanzhe Jiang
>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Chiradeep Vittal <Ch...@citrix.com>.
https://issues.apache.org/jira/browse/CLOUDSTACK-1345
On 2/1/13 10:50 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>I am working through a few remaining issues, but the intention is to
>provide VNS support in 4.1.
>Definitely file a blocker bug and I will update with resolution.
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
I am working through a few remaining issues, but the intention is to
provide VNS support in 4.1.
Definitely file a blocker bug and I will update with resolution.
On Fri, Feb 1, 2013 at 10:33 AM, Chip Childers <ch...@sungard.com>wrote:
> On Fri, Feb 1, 2013 at 12:40 PM, Chiradeep Vittal <ch...@gmail.com>
> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9131/#review16014
> > -----------------------------------------------------------
> >
> >
> > Although this has been reviewed and applied, I do have a couple more
> comments
> > - package naming convention should be org.apache.cloudstack.*
> > - if VNS support is not in the code yet, we should not be modifying the
> UI (or even adding the isolation method)
>
> Chiradeep - point one is covered by an existing bug (this obviously
> adds to the number of classes to deal with), but point two sounds like
> a new bug introduced with this commit. Do you mind creating a 4.1.0
> blocker bug for it?
>
> >
> > - Chiradeep Vittal
> >
> >
> > On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9131/
> >> -----------------------------------------------------------
> >>
> >> (Updated Feb. 1, 2013, 1:03 a.m.)
> >>
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is the first patch for BigSwitch Network Plugin to CloudStack. The
> patch follows the design spec that can be found at
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin
> .
> >>
> >>
> >> Diffs
> >> -----
> >>
> >> api/src/com/cloud/network/PhysicalNetwork.java a495092
> >> client/pom.xml 7ebe50c
> >> client/tomcatconf/commands.properties.in 755a5f2
> >> client/tomcatconf/components.xml.in c41d4f4
> >> cloud.spec 9f46dd6
> >> debian/cloud-server.install 9cd1eeb
> >> docs/en-US/Release_Notes.xml c8cc686
> >> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java
> PRE-CREATION
> >>
> plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java
> 3bd39b8
> >> plugins/pom.xml c5b6e58
> >> setup/db/create-schema.sql ead98a5
> >> tools/apidoc/gen_toc.py 7739aea
> >> ui/scripts/ui-custom/zoneWizard.js ef606e9
> >> wscript_configure 3b9377b
> >>
> >> Diff: https://reviews.apache.org/r/9131/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Verify the builds: mvn clean install;
> >> The database can be deployed;
> >> CloudStack can be launched with the plugin modules.
> >>
> >> JUnit tests of all api commands to a mock controller.
> >>
> >>
> >> Thanks,
> >>
> >> Kanzhe Jiang
> >>
> >>
> >
>
--
Kanzhe Jiang
MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Feb 1, 2013 at 12:40 PM, Chiradeep Vittal <ch...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/#review16014
> -----------------------------------------------------------
>
>
> Although this has been reviewed and applied, I do have a couple more comments
> - package naming convention should be org.apache.cloudstack.*
> - if VNS support is not in the code yet, we should not be modifying the UI (or even adding the isolation method)
Chiradeep - point one is covered by an existing bug (this obviously
adds to the number of classes to deal with), but point two sounds like
a new bug introduced with this commit. Do you mind creating a 4.1.0
blocker bug for it?
>
> - Chiradeep Vittal
>
>
> On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9131/
>> -----------------------------------------------------------
>>
>> (Updated Feb. 1, 2013, 1:03 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Description
>> -------
>>
>> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>>
>>
>> Diffs
>> -----
>>
>> api/src/com/cloud/network/PhysicalNetwork.java a495092
>> client/pom.xml 7ebe50c
>> client/tomcatconf/commands.properties.in 755a5f2
>> client/tomcatconf/components.xml.in c41d4f4
>> cloud.spec 9f46dd6
>> debian/cloud-server.install 9cd1eeb
>> docs/en-US/Release_Notes.xml c8cc686
>> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
>> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
>> plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8
>> plugins/pom.xml c5b6e58
>> setup/db/create-schema.sql ead98a5
>> tools/apidoc/gen_toc.py 7739aea
>> ui/scripts/ui-custom/zoneWizard.js ef606e9
>> wscript_configure 3b9377b
>>
>> Diff: https://reviews.apache.org/r/9131/diff/
>>
>>
>> Testing
>> -------
>>
>> Verify the builds: mvn clean install;
>> The database can be deployed;
>> CloudStack can be launched with the plugin modules.
>>
>> JUnit tests of all api commands to a mock controller.
>>
>>
>> Thanks,
>>
>> Kanzhe Jiang
>>
>>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review16014
-----------------------------------------------------------
Although this has been reviewed and applied, I do have a couple more comments
- package naming convention should be org.apache.cloudstack.*
- if VNS support is not in the code yet, we should not be modifying the UI (or even adding the isolation method)
- Chiradeep Vittal
On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 1:03 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/PhysicalNetwork.java a495092
> client/pom.xml 7ebe50c
> client/tomcatconf/commands.properties.in 755a5f2
> client/tomcatconf/components.xml.in c41d4f4
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8
> plugins/pom.xml c5b6e58
> setup/db/create-schema.sql ead98a5
> tools/apidoc/gen_toc.py 7739aea
> ui/scripts/ui-custom/zoneWizard.js ef606e9
> wscript_configure 3b9377b
>
> Diff: https://reviews.apache.org/r/9131/diff/
>
>
> Testing
> -------
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Thanks,
>
> Kanzhe Jiang
>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15990
-----------------------------------------------------------
Ship it!
Ship It!
- Murali Reddy
On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 1:03 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/PhysicalNetwork.java a495092
> client/pom.xml 7ebe50c
> client/tomcatconf/commands.properties.in 755a5f2
> client/tomcatconf/components.xml.in c41d4f4
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
> plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8
> plugins/pom.xml c5b6e58
> setup/db/create-schema.sql ead98a5
> tools/apidoc/gen_toc.py 7739aea
> ui/scripts/ui-custom/zoneWizard.js ef606e9
> wscript_configure 3b9377b
>
> Diff: https://reviews.apache.org/r/9131/diff/
>
>
> Testing
> -------
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Thanks,
>
> Kanzhe Jiang
>
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 1:03 a.m.)
Review request for cloudstack.
Changes
-------
This is the updated patch after rebasing the dev branch.
Description
-------
This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
Diffs (updated)
-----
api/src/com/cloud/network/PhysicalNetwork.java a495092
client/pom.xml 7ebe50c
client/tomcatconf/commands.properties.in 755a5f2
client/tomcatconf/components.xml.in c41d4f4
cloud.spec 9f46dd6
debian/cloud-server.install 9cd1eeb
docs/en-US/Release_Notes.xml c8cc686
plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8
plugins/pom.xml c5b6e58
setup/db/create-schema.sql ead98a5
tools/apidoc/gen_toc.py 7739aea
ui/scripts/ui-custom/zoneWizard.js ef606e9
wscript_configure 3b9377b
Diff: https://reviews.apache.org/r/9131/diff/
Testing
-------
Verify the builds: mvn clean install;
The database can be deployed;
CloudStack can be launched with the plugin modules.
JUnit tests of all api commands to a mock controller.
Thanks,
Kanzhe Jiang
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Rohit Yadav <ro...@citrix.com>.
Hi Kanzhe,
Just go through that wiki and see other apis how annotation is used,
and add/edit anything missing as well.
You may want to test your apis and make sure they work. Feel free to
reach out to me for any help regarding apis.
Regards.
On Wed, Jan 30, 2013 at 4:51 PM, Chiradeep Vittal
<Ch...@citrix.com> wrote:
> @EntityReference(FirewallRule.class)
>
> The IdentityProxy is deprecated.
>
> It looks like you have not rebased to the latest master.
>
> See this guide
> https://cwiki.apache.org/confluence/x/0wDFAQ
>
> On 1/30/13 4:20 PM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>
>>Chiradeep,
>>
>>I do not see any annotation referring to the table
>>in FirewallRuleResponse.java.
>>What am I missing here?
>>
>>Kanzhe
>>
>>On Wed, Jan 30, 2013 at 3:33 PM, Chiradeep Vittal <
>>Chiradeep.Vittal@citrix.com> wrote:
>>
>>> Any subclass of BaseResponse.
>>> For example, FirewallRuleResponse
>>>
>>> On 1/30/13 11:14 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>>>
>>> >Hi Chiradeep,
>>> >
>>> >Thank you for your review comments. I resolved all but one of your
>>> >comments
>>> >and need some clarification on
>>> >"Requires an annotation referring to the table"
>>> >
>>> >Is there any example that I can refer to?
>>> >
>>> >Thanks,
>>> >Kanzhe
>>> >
>>> >On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang
>>> ><ka...@bigswitch.com>wrote:
>>> >
>>> >> This is an automatically generated e-mail. To reply, visit:
>>> >> https://reviews.apache.org/r/9131/
>>> >> Review request for cloudstack.
>>> >> By Kanzhe Jiang.
>>> >>
>>> >> *Updated Jan. 30, 2013, 4:12 a.m.*
>>> >> Changes
>>> >>
>>> >> Updated patch based on review comments.
>>> >>
>>> >> Description
>>> >>
>>> >> This is the first patch for BigSwitch Network Plugin to CloudStack.
>>>The
>>> >>patch follows the design spec that can be found at
>>> >>
>>>
>>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networki
>>> >>ng+Plugin.
>>> >>
>>> >> Testing
>>> >>
>>> >> Verify the builds: mvn clean install;
>>> >> The database can be deployed;
>>> >> CloudStack can be launched with the plugin modules.
>>> >>
>>> >> JUnit tests of all api commands to a mock controller.
>>> >>
>>> >>
>>> >> Diffs (updated)
>>> >>
>>> >> - api/src/com/cloud/api/ApiConstants.java (78a3ded)
>>> >> - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
>>> >> - build/build-cloud-plugins.xml (207ef71)
>>> >> - build/developer.xml (fdda171)
>>> >> - client/pom.xml (1673429)
>>> >> - client/tomcatconf/bigswitch-vns_commands.properties.in
>>> >>(PRE-CREATION)
>>> >> - client/tomcatconf/components.xml.in (5957b61)
>>> >> - cloud.spec (9f46dd6)
>>> >> - debian/cloud-server.install (9cd1eeb)
>>> >> - docs/en-US/Release_Notes.xml (c8cc686)
>>> >> - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sN
>>> >>etworkAnswer.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sN
>>> >>etworkCommand.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sP
>>> >>ortAnswer.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sP
>>> >>ortCommand.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sN
>>> >>etworkAnswer.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sN
>>> >>etworkCommand.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sP
>>> >>ortAnswer.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sP
>>> >>ortCommand.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupB
>>>>>ig
>>> >>SwitchVnsCommand.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVn
>>>>>sP
>>> >>ortAnswer.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVn
>>>>>sP
>>> >>ortCommand.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBi
>>>>>gS
>>> >>witchVnsDeviceCmd.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/Delet
>>>>>eB
>>> >>igSwitchVnsDeviceCmd.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListB
>>>>>ig
>>> >>SwitchVnsDevicesCmd.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsCo
>>>>>ns
>>> >>tants.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSw
>>>>>it
>>> >>chVnsDeviceResponse.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchV
>>>>>ns
>>> >>DeviceVO.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>At
>>> >>tachment.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Bi
>>> >>gSwitchVnsApi.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Bi
>>> >>gSwitchVnsApiException.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Co
>>> >>ntrolClusterStatus.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Ne
>>> >>twork.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Po
>>> >>rt.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwi
>>>>>tc
>>> >>hVnsDao.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwi
>>>>>tc
>>> >>hVnsDaoImpl.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/Bi
>>>>>gS
>>> >>witchVnsElement.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/Bi
>>>>>gS
>>> >>witchVnsElementService.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSw
>>>>>it
>>> >>chVnsGuestNetworkGuru.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/B
>>>>>ig
>>> >>SwitchVnsResource.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch
>>>>>/B
>>> >>igSwitchApiTest.java
>>> >> (PRE-CREATION)
>>> >> -
>>>
>>>>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/
>>>>>Bi
>>> >>gSwitchVnsResourceTest.java
>>> >> (PRE-CREATION)
>>> >> - plugins/pom.xml (2009302)
>>> >> - server/src/com/cloud/network/NetworkManager.java (057f473)
>>> >> - setup/db/create-schema.sql (fff084e)
>>> >> - tools/apidoc/gen_toc.py (eeaf2a2)
>>> >> - tools/apidoc/pom.xml (b75ee82)
>>> >> - wscript_configure (3b9377b)
>>> >>
>>> >> View Diff <https://reviews.apache.org/r/9131/diff/>
>>> >>
>>> >
>>> >
>>> >
>>> >--
>>> >Kanzhe Jiang
>>> >MTS at BigSwitch
>>>
>>>
>>
>>
>>--
>>Kanzhe Jiang
>>MTS at BigSwitch
>
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Chiradeep Vittal <Ch...@citrix.com>.
@EntityReference(FirewallRule.class)
The IdentityProxy is deprecated.
It looks like you have not rebased to the latest master.
See this guide
https://cwiki.apache.org/confluence/x/0wDFAQ
On 1/30/13 4:20 PM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>Chiradeep,
>
>I do not see any annotation referring to the table
>in FirewallRuleResponse.java.
>What am I missing here?
>
>Kanzhe
>
>On Wed, Jan 30, 2013 at 3:33 PM, Chiradeep Vittal <
>Chiradeep.Vittal@citrix.com> wrote:
>
>> Any subclass of BaseResponse.
>> For example, FirewallRuleResponse
>>
>> On 1/30/13 11:14 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>>
>> >Hi Chiradeep,
>> >
>> >Thank you for your review comments. I resolved all but one of your
>> >comments
>> >and need some clarification on
>> >"Requires an annotation referring to the table"
>> >
>> >Is there any example that I can refer to?
>> >
>> >Thanks,
>> >Kanzhe
>> >
>> >On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang
>> ><ka...@bigswitch.com>wrote:
>> >
>> >> This is an automatically generated e-mail. To reply, visit:
>> >> https://reviews.apache.org/r/9131/
>> >> Review request for cloudstack.
>> >> By Kanzhe Jiang.
>> >>
>> >> *Updated Jan. 30, 2013, 4:12 a.m.*
>> >> Changes
>> >>
>> >> Updated patch based on review comments.
>> >>
>> >> Description
>> >>
>> >> This is the first patch for BigSwitch Network Plugin to CloudStack.
>>The
>> >>patch follows the design spec that can be found at
>> >>
>>
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networki
>> >>ng+Plugin.
>> >>
>> >> Testing
>> >>
>> >> Verify the builds: mvn clean install;
>> >> The database can be deployed;
>> >> CloudStack can be launched with the plugin modules.
>> >>
>> >> JUnit tests of all api commands to a mock controller.
>> >>
>> >>
>> >> Diffs (updated)
>> >>
>> >> - api/src/com/cloud/api/ApiConstants.java (78a3ded)
>> >> - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
>> >> - build/build-cloud-plugins.xml (207ef71)
>> >> - build/developer.xml (fdda171)
>> >> - client/pom.xml (1673429)
>> >> - client/tomcatconf/bigswitch-vns_commands.properties.in
>> >>(PRE-CREATION)
>> >> - client/tomcatconf/components.xml.in (5957b61)
>> >> - cloud.spec (9f46dd6)
>> >> - debian/cloud-server.install (9cd1eeb)
>> >> - docs/en-US/Release_Notes.xml (c8cc686)
>> >> - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>sN
>> >>etworkAnswer.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>sN
>> >>etworkCommand.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>sP
>> >>ortAnswer.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>sP
>> >>ortCommand.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>sN
>> >>etworkAnswer.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>sN
>> >>etworkCommand.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>sP
>> >>ortAnswer.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>sP
>> >>ortCommand.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupB
>>>>ig
>> >>SwitchVnsCommand.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVn
>>>>sP
>> >>ortAnswer.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVn
>>>>sP
>> >>ortCommand.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBi
>>>>gS
>> >>witchVnsDeviceCmd.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/Delet
>>>>eB
>> >>igSwitchVnsDeviceCmd.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListB
>>>>ig
>> >>SwitchVnsDevicesCmd.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsCo
>>>>ns
>> >>tants.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSw
>>>>it
>> >>chVnsDeviceResponse.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchV
>>>>ns
>> >>DeviceVO.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>At
>> >>tachment.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>Bi
>> >>gSwitchVnsApi.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>Bi
>> >>gSwitchVnsApiException.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>Co
>> >>ntrolClusterStatus.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>Ne
>> >>twork.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>Po
>> >>rt.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwi
>>>>tc
>> >>hVnsDao.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwi
>>>>tc
>> >>hVnsDaoImpl.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/Bi
>>>>gS
>> >>witchVnsElement.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/Bi
>>>>gS
>> >>witchVnsElementService.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSw
>>>>it
>> >>chVnsGuestNetworkGuru.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/B
>>>>ig
>> >>SwitchVnsResource.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch
>>>>/B
>> >>igSwitchApiTest.java
>> >> (PRE-CREATION)
>> >> -
>>
>>>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/
>>>>Bi
>> >>gSwitchVnsResourceTest.java
>> >> (PRE-CREATION)
>> >> - plugins/pom.xml (2009302)
>> >> - server/src/com/cloud/network/NetworkManager.java (057f473)
>> >> - setup/db/create-schema.sql (fff084e)
>> >> - tools/apidoc/gen_toc.py (eeaf2a2)
>> >> - tools/apidoc/pom.xml (b75ee82)
>> >> - wscript_configure (3b9377b)
>> >>
>> >> View Diff <https://reviews.apache.org/r/9131/diff/>
>> >>
>> >
>> >
>> >
>> >--
>> >Kanzhe Jiang
>> >MTS at BigSwitch
>>
>>
>
>
>--
>Kanzhe Jiang
>MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
Chiradeep,
I do not see any annotation referring to the table
in FirewallRuleResponse.java.
What am I missing here?
Kanzhe
On Wed, Jan 30, 2013 at 3:33 PM, Chiradeep Vittal <
Chiradeep.Vittal@citrix.com> wrote:
> Any subclass of BaseResponse.
> For example, FirewallRuleResponse
>
> On 1/30/13 11:14 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>
> >Hi Chiradeep,
> >
> >Thank you for your review comments. I resolved all but one of your
> >comments
> >and need some clarification on
> >"Requires an annotation referring to the table"
> >
> >Is there any example that I can refer to?
> >
> >Thanks,
> >Kanzhe
> >
> >On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang
> ><ka...@bigswitch.com>wrote:
> >
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9131/
> >> Review request for cloudstack.
> >> By Kanzhe Jiang.
> >>
> >> *Updated Jan. 30, 2013, 4:12 a.m.*
> >> Changes
> >>
> >> Updated patch based on review comments.
> >>
> >> Description
> >>
> >> This is the first patch for BigSwitch Network Plugin to CloudStack. The
> >>patch follows the design spec that can be found at
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networki
> >>ng+Plugin.
> >>
> >> Testing
> >>
> >> Verify the builds: mvn clean install;
> >> The database can be deployed;
> >> CloudStack can be launched with the plugin modules.
> >>
> >> JUnit tests of all api commands to a mock controller.
> >>
> >>
> >> Diffs (updated)
> >>
> >> - api/src/com/cloud/api/ApiConstants.java (78a3ded)
> >> - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
> >> - build/build-cloud-plugins.xml (207ef71)
> >> - build/developer.xml (fdda171)
> >> - client/pom.xml (1673429)
> >> - client/tomcatconf/bigswitch-vns_commands.properties.in
> >>(PRE-CREATION)
> >> - client/tomcatconf/components.xml.in (5957b61)
> >> - cloud.spec (9f46dd6)
> >> - debian/cloud-server.install (9cd1eeb)
> >> - docs/en-US/Release_Notes.xml (c8cc686)
> >> - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsN
> >>etworkAnswer.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsN
> >>etworkCommand.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsP
> >>ortAnswer.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsP
> >>ortCommand.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsN
> >>etworkAnswer.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsN
> >>etworkCommand.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsP
> >>ortAnswer.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsP
> >>ortCommand.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBig
> >>SwitchVnsCommand.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsP
> >>ortAnswer.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsP
> >>ortCommand.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigS
> >>witchVnsDeviceCmd.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteB
> >>igSwitchVnsDeviceCmd.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBig
> >>SwitchVnsDevicesCmd.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsCons
> >>tants.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwit
> >>chVnsDeviceResponse.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVns
> >>DeviceVO.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/At
> >>tachment.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Bi
> >>gSwitchVnsApi.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Bi
> >>gSwitchVnsApiException.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Co
> >>ntrolClusterStatus.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Ne
> >>twork.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Po
> >>rt.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitc
> >>hVnsDao.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitc
> >>hVnsDaoImpl.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigS
> >>witchVnsElement.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigS
> >>witchVnsElementService.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwit
> >>chVnsGuestNetworkGuru.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/Big
> >>SwitchVnsResource.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/B
> >>igSwitchApiTest.java
> >> (PRE-CREATION)
> >> -
> >>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/Bi
> >>gSwitchVnsResourceTest.java
> >> (PRE-CREATION)
> >> - plugins/pom.xml (2009302)
> >> - server/src/com/cloud/network/NetworkManager.java (057f473)
> >> - setup/db/create-schema.sql (fff084e)
> >> - tools/apidoc/gen_toc.py (eeaf2a2)
> >> - tools/apidoc/pom.xml (b75ee82)
> >> - wscript_configure (3b9377b)
> >>
> >> View Diff <https://reviews.apache.org/r/9131/diff/>
> >>
> >
> >
> >
> >--
> >Kanzhe Jiang
> >MTS at BigSwitch
>
>
--
Kanzhe Jiang
MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Chiradeep Vittal <Ch...@citrix.com>.
Any subclass of BaseResponse.
For example, FirewallRuleResponse
On 1/30/13 11:14 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>Hi Chiradeep,
>
>Thank you for your review comments. I resolved all but one of your
>comments
>and need some clarification on
>"Requires an annotation referring to the table"
>
>Is there any example that I can refer to?
>
>Thanks,
>Kanzhe
>
>On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang
><ka...@bigswitch.com>wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9131/
>> Review request for cloudstack.
>> By Kanzhe Jiang.
>>
>> *Updated Jan. 30, 2013, 4:12 a.m.*
>> Changes
>>
>> Updated patch based on review comments.
>>
>> Description
>>
>> This is the first patch for BigSwitch Network Plugin to CloudStack. The
>>patch follows the design spec that can be found at
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networki
>>ng+Plugin.
>>
>> Testing
>>
>> Verify the builds: mvn clean install;
>> The database can be deployed;
>> CloudStack can be launched with the plugin modules.
>>
>> JUnit tests of all api commands to a mock controller.
>>
>>
>> Diffs (updated)
>>
>> - api/src/com/cloud/api/ApiConstants.java (78a3ded)
>> - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
>> - build/build-cloud-plugins.xml (207ef71)
>> - build/developer.xml (fdda171)
>> - client/pom.xml (1673429)
>> - client/tomcatconf/bigswitch-vns_commands.properties.in
>>(PRE-CREATION)
>> - client/tomcatconf/components.xml.in (5957b61)
>> - cloud.spec (9f46dd6)
>> - debian/cloud-server.install (9cd1eeb)
>> - docs/en-US/Release_Notes.xml (c8cc686)
>> - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsN
>>etworkAnswer.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsN
>>etworkCommand.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsP
>>ortAnswer.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsP
>>ortCommand.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsN
>>etworkAnswer.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsN
>>etworkCommand.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsP
>>ortAnswer.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsP
>>ortCommand.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBig
>>SwitchVnsCommand.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsP
>>ortAnswer.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsP
>>ortCommand.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigS
>>witchVnsDeviceCmd.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteB
>>igSwitchVnsDeviceCmd.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBig
>>SwitchVnsDevicesCmd.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsCons
>>tants.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwit
>>chVnsDeviceResponse.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVns
>>DeviceVO.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/At
>>tachment.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Bi
>>gSwitchVnsApi.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Bi
>>gSwitchVnsApiException.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Co
>>ntrolClusterStatus.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Ne
>>twork.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Po
>>rt.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitc
>>hVnsDao.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitc
>>hVnsDaoImpl.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigS
>>witchVnsElement.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigS
>>witchVnsElementService.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwit
>>chVnsGuestNetworkGuru.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/Big
>>SwitchVnsResource.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/B
>>igSwitchApiTest.java
>> (PRE-CREATION)
>> -
>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/Bi
>>gSwitchVnsResourceTest.java
>> (PRE-CREATION)
>> - plugins/pom.xml (2009302)
>> - server/src/com/cloud/network/NetworkManager.java (057f473)
>> - setup/db/create-schema.sql (fff084e)
>> - tools/apidoc/gen_toc.py (eeaf2a2)
>> - tools/apidoc/pom.xml (b75ee82)
>> - wscript_configure (3b9377b)
>>
>> View Diff <https://reviews.apache.org/r/9131/diff/>
>>
>
>
>
>--
>Kanzhe Jiang
>MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
Hi Chiradeep,
Thank you for your review comments. I resolved all but one of your comments
and need some clarification on
"Requires an annotation referring to the table"
Is there any example that I can refer to?
Thanks,
Kanzhe
On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang <ka...@bigswitch.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> Review request for cloudstack.
> By Kanzhe Jiang.
>
> *Updated Jan. 30, 2013, 4:12 a.m.*
> Changes
>
> Updated patch based on review comments.
>
> Description
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
> Testing
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
> Diffs (updated)
>
> - api/src/com/cloud/api/ApiConstants.java (78a3ded)
> - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
> - build/build-cloud-plugins.xml (207ef71)
> - build/developer.xml (fdda171)
> - client/pom.xml (1673429)
> - client/tomcatconf/bigswitch-vns_commands.properties.in (PRE-CREATION)
> - client/tomcatconf/components.xml.in (5957b61)
> - cloud.spec (9f46dd6)
> - debian/cloud-server.install (9cd1eeb)
> - docs/en-US/Release_Notes.xml (c8cc686)
> - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java
> (PRE-CREATION)
> - plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java
> (PRE-CREATION)
> - plugins/pom.xml (2009302)
> - server/src/com/cloud/network/NetworkManager.java (057f473)
> - setup/db/create-schema.sql (fff084e)
> - tools/apidoc/gen_toc.py (eeaf2a2)
> - tools/apidoc/pom.xml (b75ee82)
> - wscript_configure (3b9377b)
>
> View Diff <https://reviews.apache.org/r/9131/diff/>
>
--
Kanzhe Jiang
MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/
-----------------------------------------------------------
(Updated Jan. 30, 2013, 4:12 a.m.)
Review request for cloudstack.
Changes
-------
Updated patch based on review comments.
Description
-------
This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
Diffs (updated)
-----
api/src/com/cloud/api/ApiConstants.java 78a3ded
api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
build/build-cloud-plugins.xml 207ef71
build/developer.xml fdda171
client/pom.xml 1673429
client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
client/tomcatconf/components.xml.in 5957b61
cloud.spec 9f46dd6
debian/cloud-server.install 9cd1eeb
docs/en-US/Release_Notes.xml c8cc686
plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
plugins/pom.xml 2009302
server/src/com/cloud/network/NetworkManager.java 057f473
setup/db/create-schema.sql fff084e
tools/apidoc/gen_toc.py eeaf2a2
tools/apidoc/pom.xml b75ee82
wscript_configure 3b9377b
Diff: https://reviews.apache.org/r/9131/diff/
Testing
-------
Verify the builds: mvn clean install;
The database can be deployed;
CloudStack can be launched with the plugin modules.
JUnit tests of all api commands to a mock controller.
Thanks,
Kanzhe Jiang
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
Hi Murali and Hugo,
For L2 isolation, there isn't much difference between Nicira NVP and
BigSwitch VNS. Obviously, the differences are on the controllers. Nicira
NVP works with OVS with Nicira extension, while BigSwitch Controller works
with stock OVS and all physical OpenFlow switches. I referenced Hugo's NVP
plugin to implement the BigSwitch one. Hence, it should be familiar to you,
Hugo.
I am still testing the plugin with the controller and will fill in the
functional testing details shortly. Given the deadline in 3 days to be
included in 4.1, I would like to start the review process first if it is ok.
The current version uses the 1.1 version of the controller API, which is
not available on floodlight yet. So the plugin won't work with floodlight
for now. The v1.1 API will be supported by floodlight shortly and I will
try to document the step as well.
In summary, this is the bulk of the plugin. I will provide update on
functional testing, documentation, and integration with floodlight shortly.
Thanks,
Kanzhe
On Tue, Jan 29, 2013 at 1:13 AM, Murali Reddy <Mu...@citrix.com>wrote:
>
> Kanze,
>
> Thanks for the patch. On first look patch look good, but I will do a
> detailed review tomorrow.
>
> Meanwhile could you help me understand how the network is
> provisioned/de-provisioned through the contrloller? I understand that you
> plan to support Vlan isolation only for 4.1, so what is the role of
> controller in this case? So when CreateNetwork, DeleteNetwork commands are
> sent by the Guru in network design/destroy phases, does controller setup's
> Vlans on the open flow enabled switches and hypervisors?
>
> Thanks,
> Murali
>
>
> On 29/01/13 11:29 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>
> >
> >-----------------------------------------------------------
> >This is an automatically generated e-mail. To reply, visit:
> >https://reviews.apache.org/r/9131/
> >-----------------------------------------------------------
> >
> >Review request for cloudstack.
> >
> >
> >Description
> >-------
> >
> >This is the first patch for BigSwitch Network Plugin to CloudStack. The
> >patch follows the design spec that can be found at
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networkin
> >g+Plugin.
> >
> >
> >Diffs
> >-----
> >
> > api/src/com/cloud/api/ApiConstants.java 78a3ded
> > api/src/com/cloud/event/EventTypes.java e69e4a4
> > api/src/com/cloud/network/Network.java d38f740
> > api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
> > build/build-cloud-plugins.xml 207ef71
> > build/developer.xml fdda171
> > client/pom.xml 1673429
> > client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
> > client/tomcatconf/components.xml.in 5957b61
> > cloud.spec 9f46dd6
> > debian/cloud-server.install 9cd1eeb
> > docs/en-US/Release_Notes.xml c8cc686
> > plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetwo
> >rkAnswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetwo
> >rkCommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortA
> >nswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortC
> >ommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetwo
> >rkAnswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetwo
> >rkCommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortA
> >nswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortC
> >ommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigS
> >witchVnsCommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortA
> >nswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortC
> >ommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSw
> >itchVnsDeviceCmd.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBi
> >gSwitchVnsDeviceCmd.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigS
> >witchVnsDevicesCmd.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitc
> >hVnsDeviceResponse.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsD
> >eviceVO.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Att
> >achment.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Big
> >SwitchVnsApi.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Big
> >SwitchVnsApiException.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Con
> >trolClusterStatus.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Net
> >work.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Por
> >t.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitch
> >VnsDao.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitch
> >VnsDaoImpl.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSw
> >itchVnsElement.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSw
> >itchVnsElementService.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitc
> >hVnsGuestNetworkGuru.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigS
> >witchVnsResource.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/Bi
> >gSwitchApiTest.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/Big
> >SwitchVnsResourceTest.java PRE-CREATION
> > plugins/pom.xml 2009302
> > server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
> > setup/db/create-schema.sql fff084e
> > tools/apidoc/gen_toc.py eeaf2a2
> > tools/apidoc/pom.xml b75ee82
> > wscript_configure 3b9377b
> >
> >Diff: https://reviews.apache.org/r/9131/diff/
> >
> >
> >Testing
> >-------
> >
> >Verify the builds: mvn clean install;
> >The database can be deployed;
> >CloudStack can be launched with the plugin modules.
> >
> >JUnit tests of all api commands to a mock controller.
> >
> >
> >Thanks,
> >
> >Kanzhe Jiang
> >
> >
>
>
>
--
Kanzhe Jiang
MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
Reply inline.
On Wed, Jan 30, 2013 at 10:11 PM, Murali Reddy <Mu...@citrix.com>wrote:
> Kanzhe,
>
> Thanks for the detailed explantation. I get the end-to-end flow now. If I
> understand correctly, every flow across the VM's in same virtual network,
> at initiation, still needs to go through the controller right?
>
Yes, controller sets up every flow int the network based on the first
packet of the flow. It is when the isolation policy is enforced. Of course,
there are more technical details in how to stop flows when isolation policy
changes, such as VM moved, change in policy. It will be best to refer to
controller document for details.
> How do you expect 'shared network' be treated. Do you expect admin to
> setup the necessary flow information through controller for shared networks?
>
>
It depends on how the network is shared, at L2 or L3. In this version of
plugin, only L2 isolation is supported. None of the L3 or inter-virtual
network functions were supported. Just think aloud here, L2 shared network
can be easily implemented with inter-virtualNetwork policy. L3 shared
network can be implemented with Virtual Routing policy.
Regards,
> Murali
>
> From: Kanzhe Jiang <ka...@bigswitch.com>
> Date: Thursday, 31 January 2013 1:28 AM
> To: Murali Reddy <mu...@citrix.com>
> Cc: "cloudstack-dev@incubator.apache.org" <
> cloudstack-dev@incubator.apache.org>
> Subject: Re: Review Request: BigSwitch VNS Networking Plugin
>
> Hi Murali,
>
> When creating network, the plugin will capture the networkUUID, tenantID,
> vlan and send a request to the controller to create a virtual network.
> Controller will create an addressSpace construct to match the vlan so that
> all device in the addressSpace has unique mac and ip, then create a virtual
> network. The membership of the virtualNetwork is based on a tag rule. A tag
> rule is that any device with the tag will be classified to the virtual
> network.
>
> When a VM is created, BigSwitchVnsElement.java will send a request to the
> controller to create a port and attachment for the VM. The port contains
> the networkuuid. The attachment contains the VM's mac address. The
> controller then associates the VM with its network tag.
>
> At this point, nothing is happening to the switches yet.
>
> When VM sends packets, the VM's network association is determined based on
> its first packet. If the destination is in the same virtual network, the
> controller will permit the flow and set up a end-to-end flow. When setting
> up the flow, vlan is programmed on the switches along the route. The
> switches can be virtual or OF-enabled physical switches.
>
> Then the network is destroyed, the plugin notifies the controller, which
> then removes the tag and virtual network.
>
> Hope the explanation clarifies the workflow.
> Let me know if you have more question.
>
> Thanks,
> Kanzhe
>
--
Kanzhe Jiang
MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Murali Reddy <Mu...@citrix.com>.
Kanzhe,
Thanks for the detailed explantation. I get the end-to-end flow now. If I understand correctly, every flow across the VM's in same virtual network, at initiation, still needs to go through the controller right?
How do you expect 'shared network' be treated. Do you expect admin to setup the necessary flow information through controller for shared networks?
Regards,
Murali
From: Kanzhe Jiang <ka...@bigswitch.com>>
Date: Thursday, 31 January 2013 1:28 AM
To: Murali Reddy <mu...@citrix.com>>
Cc: "cloudstack-dev@incubator.apache.org<ma...@incubator.apache.org>" <cl...@incubator.apache.org>>
Subject: Re: Review Request: BigSwitch VNS Networking Plugin
Hi Murali,
When creating network, the plugin will capture the networkUUID, tenantID, vlan and send a request to the controller to create a virtual network.
Controller will create an addressSpace construct to match the vlan so that all device in the addressSpace has unique mac and ip, then create a virtual network. The membership of the virtualNetwork is based on a tag rule. A tag rule is that any device with the tag will be classified to the virtual network.
When a VM is created, BigSwitchVnsElement.java will send a request to the controller to create a port and attachment for the VM. The port contains the networkuuid. The attachment contains the VM's mac address. The controller then associates the VM with its network tag.
At this point, nothing is happening to the switches yet.
When VM sends packets, the VM's network association is determined based on its first packet. If the destination is in the same virtual network, the controller will permit the flow and set up a end-to-end flow. When setting up the flow, vlan is programmed on the switches along the route. The switches can be virtual or OF-enabled physical switches.
Then the network is destroyed, the plugin notifies the controller, which then removes the tag and virtual network.
Hope the explanation clarifies the workflow.
Let me know if you have more question.
Thanks,
Kanzhe
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Kanzhe Jiang <ka...@bigswitch.com>.
Hi Murali,
When creating network, the plugin will capture the networkUUID, tenantID,
vlan and send a request to the controller to create a virtual network.
Controller will create an addressSpace construct to match the vlan so that
all device in the addressSpace has unique mac and ip, then create a virtual
network. The membership of the virtualNetwork is based on a tag rule. A tag
rule is that any device with the tag will be classified to the virtual
network.
When a VM is created, BigSwitchVnsElement.java will send a request to the
controller to create a port and attachment for the VM. The port contains
the networkuuid. The attachment contains the VM's mac address. The
controller then associates the VM with its network tag.
At this point, nothing is happening to the switches yet.
When VM sends packets, the VM's network association is determined based on
its first packet. If the destination is in the same virtual network, the
controller will permit the flow and set up a end-to-end flow. When setting
up the flow, vlan is programmed on the switches along the route. The
switches can be virtual or OF-enabled physical switches.
Then the network is destroyed, the plugin notifies the controller, which
then removes the tag and virtual network.
Hope the explanation clarifies the workflow.
Let me know if you have more question.
Thanks,
Kanzhe
On Tue, Jan 29, 2013 at 1:13 AM, Murali Reddy <Mu...@citrix.com>wrote:
>
> Kanze,
>
> Thanks for the patch. On first look patch look good, but I will do a
> detailed review tomorrow.
>
> Meanwhile could you help me understand how the network is
> provisioned/de-provisioned through the contrloller? I understand that you
> plan to support Vlan isolation only for 4.1, so what is the role of
> controller in this case? So when CreateNetwork, DeleteNetwork commands are
> sent by the Guru in network design/destroy phases, does controller setup's
> Vlans on the open flow enabled switches and hypervisors?
>
> Thanks,
> Murali
>
>
> On 29/01/13 11:29 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>
> >
> >-----------------------------------------------------------
> >This is an automatically generated e-mail. To reply, visit:
> >https://reviews.apache.org/r/9131/
> >-----------------------------------------------------------
> >
> >Review request for cloudstack.
> >
> >
> >Description
> >-------
> >
> >This is the first patch for BigSwitch Network Plugin to CloudStack. The
> >patch follows the design spec that can be found at
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networkin
> >g+Plugin.
> >
> >
> >Diffs
> >-----
> >
> > api/src/com/cloud/api/ApiConstants.java 78a3ded
> > api/src/com/cloud/event/EventTypes.java e69e4a4
> > api/src/com/cloud/network/Network.java d38f740
> > api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
> > build/build-cloud-plugins.xml 207ef71
> > build/developer.xml fdda171
> > client/pom.xml 1673429
> > client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
> > client/tomcatconf/components.xml.in 5957b61
> > cloud.spec 9f46dd6
> > debian/cloud-server.install 9cd1eeb
> > docs/en-US/Release_Notes.xml c8cc686
> > plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetwo
> >rkAnswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetwo
> >rkCommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortA
> >nswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortC
> >ommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetwo
> >rkAnswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetwo
> >rkCommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortA
> >nswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortC
> >ommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigS
> >witchVnsCommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortA
> >nswer.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortC
> >ommand.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSw
> >itchVnsDeviceCmd.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBi
> >gSwitchVnsDeviceCmd.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigS
> >witchVnsDevicesCmd.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitc
> >hVnsDeviceResponse.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsD
> >eviceVO.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Att
> >achment.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Big
> >SwitchVnsApi.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Big
> >SwitchVnsApiException.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Con
> >trolClusterStatus.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Net
> >work.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Por
> >t.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitch
> >VnsDao.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitch
> >VnsDaoImpl.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSw
> >itchVnsElement.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSw
> >itchVnsElementService.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitc
> >hVnsGuestNetworkGuru.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigS
> >witchVnsResource.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/Bi
> >gSwitchApiTest.java PRE-CREATION
> >
> >plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/Big
> >SwitchVnsResourceTest.java PRE-CREATION
> > plugins/pom.xml 2009302
> > server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
> > setup/db/create-schema.sql fff084e
> > tools/apidoc/gen_toc.py eeaf2a2
> > tools/apidoc/pom.xml b75ee82
> > wscript_configure 3b9377b
> >
> >Diff: https://reviews.apache.org/r/9131/diff/
> >
> >
> >Testing
> >-------
> >
> >Verify the builds: mvn clean install;
> >The database can be deployed;
> >CloudStack can be launched with the plugin modules.
> >
> >JUnit tests of all api commands to a mock controller.
> >
> >
> >Thanks,
> >
> >Kanzhe Jiang
> >
> >
>
>
>
--
Kanzhe Jiang
MTS at BigSwitch
Re: Review Request: BigSwitch VNS Networking Plugin
Posted by Murali Reddy <Mu...@citrix.com>.
Kanze,
Thanks for the patch. On first look patch look good, but I will do a
detailed review tomorrow.
Meanwhile could you help me understand how the network is
provisioned/de-provisioned through the contrloller? I understand that you
plan to support Vlan isolation only for 4.1, so what is the role of
controller in this case? So when CreateNetwork, DeleteNetwork commands are
sent by the Guru in network design/destroy phases, does controller setup's
Vlans on the open flow enabled switches and hypervisors?
Thanks,
Murali
On 29/01/13 11:29 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9131/
>-----------------------------------------------------------
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>This is the first patch for BigSwitch Network Plugin to CloudStack. The
>patch follows the design spec that can be found at
>https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networkin
>g+Plugin.
>
>
>Diffs
>-----
>
> api/src/com/cloud/api/ApiConstants.java 78a3ded
> api/src/com/cloud/event/EventTypes.java e69e4a4
> api/src/com/cloud/network/Network.java d38f740
> api/src/com/cloud/network/PhysicalNetwork.java be4b1d0
> build/build-cloud-plugins.xml 207ef71
> build/developer.xml fdda171
> client/pom.xml 1673429
> client/tomcatconf/bigswitch-vns_commands.properties.in PRE-CREATION
> client/tomcatconf/components.xml.in 5957b61
> cloud.spec 9f46dd6
> debian/cloud-server.install 9cd1eeb
> docs/en-US/Release_Notes.xml c8cc686
> plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetwo
>rkAnswer.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateNetwo
>rkCommand.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortA
>nswer.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreatePortC
>ommand.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetwo
>rkAnswer.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteNetwo
>rkCommand.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortA
>nswer.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeletePortC
>ommand.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigS
>witchVnsCommand.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortA
>nswer.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdatePortC
>ommand.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSw
>itchVnsDeviceCmd.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBi
>gSwitchVnsDeviceCmd.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigS
>witchVnsDevicesCmd.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitc
>hVnsDeviceResponse.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsD
>eviceVO.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Att
>achment.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Big
>SwitchVnsApi.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Big
>SwitchVnsApiException.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Con
>trolClusterStatus.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Net
>work.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Por
>t.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitch
>VnsDao.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitch
>VnsDaoImpl.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSw
>itchVnsElement.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSw
>itchVnsElementService.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitc
>hVnsGuestNetworkGuru.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigS
>witchVnsResource.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/Bi
>gSwitchApiTest.java PRE-CREATION
>
>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/Big
>SwitchVnsResourceTest.java PRE-CREATION
> plugins/pom.xml 2009302
> server/src/com/cloud/network/ExternalNetworkDeviceManager.java b1de86f
> setup/db/create-schema.sql fff084e
> tools/apidoc/gen_toc.py eeaf2a2
> tools/apidoc/pom.xml b75ee82
> wscript_configure 3b9377b
>
>Diff: https://reviews.apache.org/r/9131/diff/
>
>
>Testing
>-------
>
>Verify the builds: mvn clean install;
>The database can be deployed;
>CloudStack can be launched with the plugin modules.
>
>JUnit tests of all api commands to a mock controller.
>
>
>Thanks,
>
>Kanzhe Jiang
>
>