Re: [PR] HIVE-29234: Iceberg: Validate HMS REST Catalog Client with OAuth2 [hive]

["okumin (via GitHub)" <gi...@apache.org>]

okumin commented on code in PR #6124:
URL: https://github.com/apache/hive/pull/6124#discussion_r2418422638


##########
itests/qtest-iceberg/src/test/java/org/apache/hadoop/hive/cli/TestIcebergRESTCatalogGravitinoLlapLocalCliDriver.java:
##########
@@ -276,12 +300,27 @@ private void prepareGravitinoConfig() throws IOException {
 
     String updatedContent = content
         .replace("/WAREHOUSE_DIR", warehouseDir.toString())
+        .replace("OAUTH2_SERVER_URI", oAuth2AuthorizationServer.getIssuer())
+        .replace("OAUTH2_JWKS_URI", getJwksUri())
+        .replace("OAUTH2_CLIENT_ID", OAUTH2_SERVER_ICEBERG_CLIENT_ID)
+        .replace("OAUTH2_CLIENT_SECRET", OAUTH2_SERVER_ICEBERG_CLIENT_SECRET)
+//        .replace("localhost", "host.docker.internal")

Review Comment:
   Can we remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org