You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/02/12 03:48:39 UTC

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#4).

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................

[common] fix function Schema::Reset(cols, ...)

When I fix a tool bug (https://gerrit.cloudera.org/c/18169/),
I find Schema::Reset(cols, ...) seems not what we expect,
and in my opinion, it's a bug.

The fixing is no confluence to all unit tests.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>