[GitHub] [hadoop] steveloughran commented on a diff in pull request #5364: HDFS-16911. Distcp with snapshot diff to support Ozone filesystem.

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #5364:
URL: https://github.com/apache/hadoop/pull/5364#discussion_r1098966272


##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java:
##########
@@ -165,6 +169,23 @@ private boolean preSyncCheck() throws IOException {
     return true;
   }
 
+  protected void checkFilesystemSupport(FileSystem srcFs, FileSystem tgtFs) {

Review Comment:
   add javadocs



##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java:
##########
@@ -286,6 +297,23 @@ private boolean getAllDiffs() throws IOException {
     return false;
   }
 
+  protected SnapshotDiffReport getSnapshotDiffReport(Path ssDir,

Review Comment:
   javadocs



##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpConstants.java:
##########
@@ -122,6 +122,8 @@ private DistCpConstants() {
   /* DistCp CopyListing class override param */
   public static final String CONF_LABEL_COPY_LISTING_CLASS = "distcp.copy.listing.class";
 
+  public static final String CONF_LABEL_DISTCP_SYNC_CLASS = "distcp.sync.class";

Review Comment:
   javadocs to explain what it does. the distcp markdown docs will need to mention it too, maybe, or at least add a section about working with ozone saying "read the ozone docs"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org