[GitHub] [arrow] jonkeane commented on a change in pull request #10383: ARROW-12777: [R] Convert all inputs to Arrow objects in match_arrow and is_in

[GitBox <gi...@apache.org>]

jonkeane commented on a change in pull request #10383:
URL: https://github.com/apache/arrow/pull/10383#discussion_r640931089



##########
File path: r/R/compute.R
##########
@@ -241,13 +241,11 @@ all.ArrowDatum <- function(..., na.rm = FALSE){
 #' `boolean`-type `Array` of the same length as `x` with values indicating
 #' per element of `x` it it is present in `table`.
 #' @export
-match_arrow <- function(x, table, ...) UseMethod("match_arrow")
-
-#' @export
-match_arrow.default <- function(x, table, ...) match(x, table, ...)

Review comment:
       This is probably over-board, but we are changing the behavior here, might we want a warning here (maybe temporary? maybe only once per session) in the case where both `x` and `table` are not Arrow objects and mention that this behavior is different? 
   
   Maybe an entry in news describing this would be sufficient. The use of `match_arrow()` to dispatch `base::match()` is certainly an off-label use




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org