You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/11/20 23:30:44 UTC

[jira] Created: (THRIFT-211) Support "tethered" clients for Erlang

Support "tethered" clients for Erlang
-------------------------------------

                 Key: THRIFT-211
                 URL: https://issues.apache.org/jira/browse/THRIFT-211
             Project: Thrift
          Issue Type: New Feature
            Reporter: David Reiss


http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD

    Add a client option that causes clients to monitor their creators
    and terminate when the creator dies.  This makes it possible to
    prevent client leaks without linking, because the latter causes
    application code to be killed when a transport error occurs and
    exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "Eugene Letuchy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694381#action_12694381 ] 

Eugene Letuchy commented on THRIFT-211:
---------------------------------------

1/ Unify the setup of {Starter, Opts} so that you don't have to do the monitor keysearch twice.
2/ Consider checking the source of the DOWN message ... having an unverified DOWN message could lead to some very hard-to-trace bugs.

Lg otherwise. 

Also, what do you think about converting all the Erl unit tests to use eunit at some point (now that it's standard as of R12B) ? 

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688846#action_12688846 ] 

David Reiss commented on THRIFT-211:
------------------------------------

It should be reviewed first.  Todd, Chris, or Eugene, want to jump in?

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss reassigned THRIFT-211:
----------------------------------

    Assignee: David Reiss

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment: t211-incr.patch

This is an approximate incremental diff of the interesting changes.  interdiff didn't get the context quite right, but I think the content is right.

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, t211-incr.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment:     (was: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch)

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-211.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.2

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>             Fix For: 0.2
>
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, t211-incr.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694820#action_12694820 ] 

David Reiss commented on THRIFT-211:
------------------------------------

I changed my mind.  Now they are more unified.

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment:     (was: 0003-THRIFT-211.-erlang-Support-tethered-clients.patch)

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment:     (was: 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch)

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment: 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
                0003-THRIFT-211.-erlang-Support-tethered-clients.patch
                0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch
                0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment:     (was: 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch)

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694815#action_12694815 ] 

David Reiss commented on THRIFT-211:
------------------------------------

Replaced tabs with spaces (oops).  Fixed #1.  Is this unified enough to you?  It eliminates the double search.  It is not super-unified, but unifying them more would be kind of gross.

For 2, I did consider it, but who would forge a 'DOWN' message?  Verifying it just requires more state.

I think converting to eunit would be great.

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment: 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
                0003-THRIFT-211.-erlang-Support-tethered-clients.patch
                0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch
                0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688477#action_12688477 ] 

Bryan Duxbury commented on THRIFT-211:
--------------------------------------

Can this be committed?

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-211:
-------------------------------

    Attachment: 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
                0003-THRIFT-211.-erlang-Support-tethered-clients.patch
                0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch
                0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch

> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-211) Support "tethered" clients for Erlang

Posted by "Eugene Letuchy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704133#action_12704133 ] 

Eugene Letuchy commented on THRIFT-211:
---------------------------------------

OK. This is probably good enough to check in. I don't remember if erlang:monitor has a monopoly on DOWN messages, so hence there's some reason to at least add a guard clause (is_reference() on the monitor_ref) to make sure that it's in the right format.


> Support "tethered" clients for Erlang
> -------------------------------------
>
>                 Key: THRIFT-211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-211
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0001-THRIFT-211.-erlang-Support-unlinked-Thrift-clients.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0002-THRIFT-211.-erlang-Allow-clients-to-be-created-with.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0003-THRIFT-211.-erlang-Support-tethered-clients.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, 0004-THRIFT-211.-erlang-Modify-test_tether-to-test-proto.patch, t211-incr.patch
>
>
> http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/erl-tether;hb=HEAD
>     Add a client option that causes clients to monitor their creators
>     and terminate when the creator dies.  This makes it possible to
>     prevent client leaks without linking, because the latter causes
>     application code to be killed when a transport error occurs and
>     exits are not trapped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.