You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org> on 2023/03/10 05:35:27 UTC

[Impala-ASF-CR] IMPALA-11925: Added a new api add write notification log in batch in the MetastoreServiceHandler class

Hello Quanlong Huang, Aman Sinha, Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, John Sherman, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19508

to look at the new patch set (#4).

Change subject: IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class
......................................................................

IMPALA-11925: Added a new api add_write_notification_log_in_batch in the MetastoreServiceHandler class

In the MetastoreServiceHandler class, the
'add_write_notification_log_in_batch' API
implementation is missing which is causing
test failures. This needs to be fixed by
adding implementation of the
'add_write_notification_log_in_batch'
api in the MetastoreServiceHandler class

Testing:
Added a test in the 'test_hms_apis()' to verify that the
'add_write_notification_log_in_batch' api in HMS is reachable from impala.
The same test can be used in the future to test newly added
apis in HMS.

Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
---
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
2 files changed, 24 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19508/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9a35557c2ed79ed0276c4a418b5292fc6dd6194
Gerrit-Change-Number: 19508
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>