You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Shuai Lin <li...@gmail.com> on 2016/02/09 03:41:59 UTC

Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43353/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-4571
    https://issues.apache.org/jira/browse/MESOS-4571


Repository: mesos


Description
-------

Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.


Diffs
-----

  src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 

Diff: https://reviews.apache.org/r/43353/diff/


Testing
-------

`sudo make check -j4 GTEST_FILTER='SlaveRecoveryTest*.RecoverStatusUpdateManager'` on ubuntu 14.04


Thanks,

Shuai Lin


Re: Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43353/#review118427
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Feb. 9, 2016, 2:41 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43353/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 2:41 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4571
>     https://issues.apache.org/jira/browse/MESOS-4571
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 
> 
> Diff: https://reviews.apache.org/r/43353/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check -j4 GTEST_FILTER='SlaveRecoveryTest*.RecoverStatusUpdateManager'` on ubuntu 14.04
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Re: Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43353/#review118359
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43353]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 9, 2016, 2:41 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43353/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 2:41 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4571
>     https://issues.apache.org/jira/browse/MESOS-4571
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp bccdf37ced5de8e759c6abb91337e7bfecc77b77 
> 
> Diff: https://reviews.apache.org/r/43353/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check -j4 GTEST_FILTER='SlaveRecoveryTest*.RecoverStatusUpdateManager'` on ubuntu 14.04
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>