You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jose-torres <gi...@git.apache.org> on 2018/05/16 17:12:15 UTC

[GitHub] spark pull request #21253: [SPARK-24158][SS] Enable no-data batches for stre...

Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21253#discussion_r188703325
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala ---
    @@ -568,14 +567,16 @@ class StreamingOuterJoinSuite extends StreamTest with StateStoreMetricsTest with
         testStream(joined)(
           // Test inner part of the join.
           MultiAddData(leftInput, 1, 2, 3, 4, 5)(rightInput, 3, 4, 5, 6, 7),
    -      CheckLastBatch((3, 10, 6, 9), (4, 10, 8, 12), (5, 10, 10, 15)),
    +      CheckNewAnswer((3, 10, 6, 9), (4, 10, 8, 12), (5, 10, 10, 15)),
    +
           // Old state doesn't get dropped until the batch *after* it gets introduced, so the
    --- End diff --
    
    (here and in other tests)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org