You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "timtebeek (via GitHub)" <gi...@apache.org> on 2023/03/19 13:36:24 UTC
[GitHub] [maven] timtebeek opened a new pull request, #1067: [MNG-6825] Replace FileUtils with Commons IO
timtebeek opened a new pull request, #1067:
URL: https://github.com/apache/maven/pull/1067
For: https://issues.apache.org/jira/browse/MNG-6825
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #1067: [MNG-6825] Replace FileUtils with Commons IO
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1067:
URL: https://github.com/apache/maven/pull/1067#issuecomment-1475382802
Could we just switch to the nio api which provides a bunch of helper methods ? I'd rather remove dependencies than adding one....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] elharo commented on pull request #1067: [MNG-6825] Replace FileUtils with Commons IO
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #1067:
URL: https://github.com/apache/maven/pull/1067#issuecomment-1475319246
Failure looks flaky and unrelated:
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (checkstyle-check) on project core-its: Execution checkstyle-check of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven:maven-artifact:jar:3.0 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/maven-artifact/3.0/maven-artifact-3.0.jar: Connect to repo.maven.apache.org:443 [repo.maven.apache.org/146.75.28.215] failed: Connection timed out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] timtebeek commented on pull request #1067: [MNG-6825] Replace FileUtils with Commons IO
Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #1067:
URL: https://github.com/apache/maven/pull/1067#issuecomment-1475259722
This PR was largely created through: https://github.com/timtebeek/maven-rewrite/blob/main/file-utils.yml
It's not yet a complete migration, as [a few cases need dedicated recipes](https://github.com/timtebeek/maven-rewrite/blob/0f80732db3959183d171e451f8c9284e9bedb99d/file-utils.yml#L47-L59), or manual work to convert completely, depending on how much they are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] elharo merged pull request #1067: [MNG-6825] Replace FileUtils with Commons IO
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #1067:
URL: https://github.com/apache/maven/pull/1067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #1067: [MNG-6825] Replace FileUtils with Commons IO
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1067:
URL: https://github.com/apache/maven/pull/1067#issuecomment-1475383401
> Could we just switch to the nio api which provides a bunch of helper methods ? I'd rather remove dependencies than adding one....
I think yes, with a little bit of effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] elharo commented on pull request #1067: [MNG-6825] Replace FileUtils with Commons IO
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #1067:
URL: https://github.com/apache/maven/pull/1067#issuecomment-1475385864
Not everything in this PR is covered by NIO in Java 8. As of Java 11 though we should be able to remove most uses of Apache Commons IO too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org