[GitHub] [hive] mbathori-cloudera commented on a change in pull request #2919: HIVE-25667: Unify code managing JDBC databases in tests

[GitBox <gi...@apache.org>]

mbathori-cloudera commented on a change in pull request #2919:
URL: https://github.com/apache/hive/pull/2919#discussion_r781537846



##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/AbstractDatabase.java
##########
@@ -0,0 +1,302 @@
+package org.apache.hadoop.hive.metastore.dbinstall;

Review comment:
       Yes I felt that the metastore isn’t the right place for this class but didn't know where should it be, I’ll move it into the hive-testutils module.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org