You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 23:22:33 UTC

[GitHub] [beam] damccorm opened a new issue, #21388: Increase unit testing coverage in the dataflowlib package

damccorm opened a new issue, #21388:
URL: https://github.com/apache/beam/issues/21388

   Increase unit testing coverage in the [dataflowlib package](https://github.com/apache/beam/tree/release-2.36.0/sdks/go/pkg/beam/runners/dataflow/dataflowlib)
   
   We want code coverage at or above 50%, it is currently at 17.2%.
   
   There are plenty of helper functions to unit test, but a more thorough testing suite will require mocking interactions with Dataflow.
   
   Imported from Jira [BEAM-13914](https://issues.apache.org/jira/browse/BEAM-13914). Original Jira may contain additional context.
   Reported by: jrmccluskey.
   Subtask of issue #21383


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Increase unit testing coverage in the dataflowlib package [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.

damccorm commented on issue #21388:
URL: https://github.com/apache/beam/issues/21388#issuecomment-1819300639

   Tagging some folks who may be able to help: @lostluck @johannaojeling @jrmccluskey 
   
   At a high level, this ticket basically involves: (1) looking at https://app.codecov.io/gh/apache/beam/tree/master/sdks%2Fgo%2Fpkg%2Fbeam%2Frunners%2Fdataflow%2Fdataflowlib to see where gaps exist in our current coverage of this package (look for uncovered lines), (2) adding one or more tests that exercise some of those uncovered lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Increase unit testing coverage in the dataflowlib package [beam]

Posted by "johannaojeling (via GitHub)" <gi...@apache.org>.

johannaojeling commented on issue #21388:
URL: https://github.com/apache/beam/issues/21388#issuecomment-1819509064

   Thanks for offering to help @knabeel77! As @damccorm mentions, Codecov will show where coverage is low.
   
   As an example, a good place to start may be writing unit tests for [findDisplayDataType](https://github.com/apache/beam/blob/3439d6ab25934d390401b49f123617187fdcd318/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go#L172) invoked by [newDisplayData](https://github.com/apache/beam/blob/3439d6ab25934d390401b49f123617187fdcd318/sdks/go/pkg/beam/runners/dataflow/dataflowlib/messages.go#L185), which both lack coverage and don't rely on any external dependencies?
   
   There are some nice table-driven tests in [job_test.go](https://github.com/apache/beam/blob/3439d6ab25934d390401b49f123617187fdcd318/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job_test.go) in the same directory that you could take inspiration from.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Increase unit testing coverage in the dataflowlib package [beam]

Posted by "knabeel77 (via GitHub)" <gi...@apache.org>.

knabeel77 commented on issue #21388:
URL: https://github.com/apache/beam/issues/21388#issuecomment-1818016048

   I would like to work on this but I don't know where to start any help would be appreciated
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org