[GitHub] [cloudstack] shwstppr commented on a change in pull request #5390: server: fix reset sshkey is broken in master/4.16

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #5390:
URL: https://github.com/apache/cloudstack/pull/5390#discussion_r703279469



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -892,6 +892,7 @@ public UserVm resetVMSSHKey(ResetVMSSHKeyCmd cmd) throws ResourceUnavailableExce
     }
 
     protected void removeEncryptedPasswordFromUserVmVoDetails(UserVmVO userVmVo) {
+        _vmDao.loadDetails(userVmVo);

Review comment:
       @weizhouapache I'm not sure but instead of loading all details, removing one detail and then storing all details, can we do:
   ```
           userVmDetailsDao.removeDetail(userVmVo.getId(), VmDetailConstants.ENCRYPTED_PASSWORD);
           _vmDao.loadDetails(userVmVo);
   ```
   Also in the caller of this method we load details (ln 859), not sure if that is needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org