You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "kasjer (via GitHub)" <gi...@apache.org> on 2024/04/26 12:30:23 UTC
[PR] hw/bsp: Add support for WeAct STM32G431 board [mynewt-core]
kasjer opened a new pull request, #3209:
URL: https://github.com/apache/mynewt-core/pull/3209
This adds support for chip STM32G431 board with just one area for bootloader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/bsp: Add support for WeAct STM32G431 board [mynewt-core]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer merged PR #3209:
URL: https://github.com/apache/mynewt-core/pull/3209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/bsp: Add support for WeAct STM32G431 board [mynewt-core]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #3209:
URL: https://github.com/apache/mynewt-core/pull/3209#discussion_r1611141823
##########
hw/bsp/weact_g431cb/include/bsp/stm32g4xx_hal_conf.h:
##########
@@ -0,0 +1,381 @@
+/**
Review Comment:
what license is this? BSD? should likely be listed in LICENSE file (not sure why CI didn't catch missing RAT exclude)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/bsp: Add support for WeAct STM32G431 board [mynewt-core]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on code in PR #3209:
URL: https://github.com/apache/mynewt-core/pull/3209#discussion_r1611418943
##########
hw/bsp/weact_g431cb/include/bsp/stm32g4xx_hal_conf.h:
##########
@@ -0,0 +1,381 @@
+/**
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/bsp: Add support for WeAct STM32G431 board [mynewt-core]
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer commented on code in PR #3209:
URL: https://github.com/apache/mynewt-core/pull/3209#discussion_r1611269051
##########
hw/bsp/weact_g431cb/include/bsp/stm32g4xx_hal_conf.h:
##########
@@ -0,0 +1,381 @@
+/**
Review Comment:
file with the same name is excluded for nucleo-g491re
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] hw/bsp: Add support for WeAct STM32G431 board [mynewt-core]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #3209:
URL: https://github.com/apache/mynewt-core/pull/3209#discussion_r1611295168
##########
hw/bsp/weact_g431cb/include/bsp/stm32g4xx_hal_conf.h:
##########
@@ -0,0 +1,381 @@
+/**
Review Comment:
stil should be explicitly listed in LICENSE file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org