You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/02 23:13:29 UTC
[GitHub] [tvm] mdw-octoml opened a new pull request #8181: Fix incorrect device name in TVMC.
mdw-octoml opened a new pull request #8181:
URL: https://github.com/apache/tvm/pull/8181
Small bug in TVMC where the command line flag expects `--device gpu` but the runner code expects `--device cuda`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] YuchenJin commented on pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
YuchenJin commented on pull request #8181:
URL: https://github.com/apache/tvm/pull/8181#issuecomment-853555093
@mdw-octoml Thanks for catching the bug! I missed renaming "gpu" to "cuda" in the command line flag in PR #8032. I prefer using "cuda" as the device type because it is more consistent with other parts of the tvm code, for example, we are using `tvm.cuda()` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] YuchenJin commented on pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
YuchenJin commented on pull request #8181:
URL: https://github.com/apache/tvm/pull/8181#issuecomment-853555093
@mdw-octoml Thanks for catching the bug! I missed renaming "gpu" to "cuda" in the command line flag in PR #8032. I prefer using "cuda" as the device type because it is more consistent with other parts of the tvm code, for example, we are using `tvm.cuda()` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #8181:
URL: https://github.com/apache/tvm/pull/8181#issuecomment-853442304
@euntaik @YuchenJin Not sure what your preference is for the command-line flag for --device in TVMC, this PR makes it "gpu" consistently. Happy to change it to "cuda" if you prefer that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #8181:
URL: https://github.com/apache/tvm/pull/8181#issuecomment-854144210
Great! Renamed to "cuda".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #8181:
URL: https://github.com/apache/tvm/pull/8181#issuecomment-854156095
Who can merge this when CI passes? @jwfromm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mdw-octoml commented on pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
mdw-octoml commented on pull request #8181:
URL: https://github.com/apache/tvm/pull/8181#issuecomment-853442304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8181: Fix incorrect device name in TVMC.
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8181:
URL: https://github.com/apache/tvm/pull/8181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org