You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Myrna van Lunteren (JIRA)" <de...@db.apache.org> on 2006/01/30 19:05:41 UTC
[jira] Created: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
--------------------------------------------------------------------------------------
Key: DERBY-891
URL: http://issues.apache.org/jira/browse/DERBY-891
Project: Derby
Type: Bug
Components: Test
Versions: 10.2.0.0
Reporter: Myrna van Lunteren
Assigned to: Myrna van Lunteren
Priority: Minor
The derby_tests.policy file uses references to csinfo and db2j.
These are left-overs from pre-contribution and rename to apache and should get cleaned up.
I suspect that the db2j references can simply be taken out, but that should get double-checked.
The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
I propose to change the name of these properties as follows:
csinfo.codejar - URL to the jar files when they are in the classpath
change to derby.codejar
csinfo.codeclasses - URL to the classes directory when it is in the classpath
change to derby.codeclasses
csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
the comment said : // Only required due to a BUG.
Need to figure out which 'BUG' that is and document better
change to derby.codedir
csinfo.trustedhost
change to derby.clienthost
document: - specifies the clients ip address/hostName.
csinfo.serverhost
change to derby.serverhost
document: -Host name or ip where network server is started.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Myrna van Lunteren (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=all ]
Myrna van Lunteren updated DERBY-891:
-------------------------------------
Other Info: [Patch available]
Priority: Trivial (was: Minor)
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Myrna van Lunteren (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=all ]
Myrna van Lunteren closed DERBY-891:
------------------------------------
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Fix For: 10.2.0.0
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat, DERBY-891_020206.diff, DERBY-891_020206.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364896 ]
Kathey Marsden commented on DERBY-891:
--------------------------------------
Thanks myrna. I will look at committing this patch.
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=all ]
Daniel John Debrunner resolved DERBY-891:
-----------------------------------------
Fix Version: 10.2.0.0
Resolution: Fixed
Committed revision 374683 - thanks for the patch
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Fix For: 10.2.0.0
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat, DERBY-891_020206.diff, DERBY-891_020206.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364491 ]
Daniel John Debrunner commented on DERBY-891:
---------------------------------------------
The db2j. references are required, it's the prefix of some properties used by some test code, unit tests in the store I believe.
The bug for csinfo.codedir, is DERBY-622, it's referenced in the policy file where csinfo.codedir is used.
It's fine to change the name of these properties, but I personally don't see any real need to do so. These are properties for the testing harness, not for the Derby engine or network server. If they are changed they should be changed to a name space related to derbyTesting, and not 'derby.'. So possible names are:
derbyTesting,codejar
derbyTesting.codeclasses
etc.
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Minor
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Daniel John Debrunner (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364932 ]
Daniel John Debrunner commented on DERBY-891:
---------------------------------------------
Myrna and/or Kathey did you run the tests with jars or classes or both? On any major policy file change I found it was best to run both combinations and in some cases all four (sane/insane combined with jar/classes).
The only change I question is the removal of this permission from derbynet.jar
- permission java.net.SocketPermission "${csinfo.serverhost}", "accept,connect";
I would have thought that was needed for remote testing, maybe the intention was to add it back in a separate patch?
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364930 ]
Kathey Marsden commented on DERBY-891:
--------------------------------------
I applied this patch and ran derbyall and it it passed, but I was not entirely sure about the permissions changes at this late hour. If another committer could take a look at the policy file changes and commit this I'd appreciate it as I will be out tomorrow.
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=comments#action_12364936 ]
Kathey Marsden commented on DERBY-891:
--------------------------------------
I only ran with the classes
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-891) derby_tests.policy file contains
references to csinfo and db2j - should get cleaned up
Posted by "Myrna van Lunteren (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-891?page=all ]
Myrna van Lunteren updated DERBY-891:
-------------------------------------
Attachment: DERBY-891_020206.stat
DERBY-891_020206.diff
I had previously run derbyall with sane jars.
Following the discussion on derby-dev, here is an updated patch.
For this, I have only run supersimple, with DerbyNet, DerbyNetClient, embedded, with classes and insame jars.
Note that this patch has 2 changes over the previous one:
- derbynet.jar lists serverhost also
- I removed the word 'manually' from the comment.
Note also that in this version, there is still one line in addition to the name changes - derbyclient has an
additional: permission java.net.SocketPermission "${derbyTesting.serverhost}", "connect,resolve";
If this is not ok, I'll strip it out & resubmit...
> derby_tests.policy file contains references to csinfo and db2j - should get cleaned up
> --------------------------------------------------------------------------------------
>
> Key: DERBY-891
> URL: http://issues.apache.org/jira/browse/DERBY-891
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Myrna van Lunteren
> Assignee: Myrna van Lunteren
> Priority: Trivial
> Attachments: DERBY-891_013106.diff, DERBY-891_013106.stat, DERBY-891_020206.diff, DERBY-891_020206.stat
>
> The derby_tests.policy file uses references to csinfo and db2j.
> These are left-overs from pre-contribution and rename to apache and should get cleaned up.
> I suspect that the db2j references can simply be taken out, but that should get double-checked.
> The csinfo references are used in jvm.java. There referenced in the testing/README.htm.
> I propose to change the name of these properties as follows:
> csinfo.codejar - URL to the jar files when they are in the classpath
> change to derby.codejar
> csinfo.codeclasses - URL to the classes directory when it is in the classpath
> change to derby.codeclasses
> csinfo.codedir - File location of either csinfo.codejar or csinfo.codejar.
> the comment said : // Only required due to a BUG.
> Need to figure out which 'BUG' that is and document better
> change to derby.codedir
> csinfo.trustedhost
> change to derby.clienthost
> document: - specifies the clients ip address/hostName.
> csinfo.serverhost
> change to derby.serverhost
> document: -Host name or ip where network server is started.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira