[GitHub] [kafka] OmniaGM commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

["OmniaGM (via GitHub)" <gi...@apache.org>]

OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r1103879807


##########
build.gradle:
##########
@@ -1756,6 +1756,7 @@ project(':tools') {
 
   dependencies {
     implementation project(':clients')
+    implementation project(':core')

Review Comment:
   It would be bit harder to move them to tools. For example the command uses `kafka.utils.json` which is used by `kafka.server`, `kafka.security.authorizer`. And `kafka.admin.AdminOperationException` is used by `kafka.admin`, `kafka.controller`, `kafka.zk`, etc. So not sure it's easy to move them out. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org