You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/08/07 08:13:26 UTC
Review Request 24444: CLOUDSTACK-7277: Removed the Hyper-V Agent service
dependency on english locale to sync VMs properly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24444/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-7277
https://issues.apache.org/jira/browse/CLOUDSTACK-7277
Repository: cloudstack-git
Description
-------
For vmsync first VMs are listed and than their power state is determined.
To exclude hosted system we filter the result on Caption='Virtual Machine' but this string is locale dependent so it may not
not work properly for locales other than english. To overcome this now we started using ProcessId >= 0 filter
Diffs
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 195a964
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs b2a7b45
Diff: https://reviews.apache.org/r/24444/diff/
Testing
-------
tested on my local system with ProcessId >= 0 filter VMs are syncing up properly
Thanks,
Anshul Gangwar
Re: Review Request 24444: CLOUDSTACK-7277: Removed the Hyper-V Agent
service dependency on english locale to sync VMs properly
Posted by Devdeep Singh <de...@citrix.com>.
> On Aug. 18, 2014, 6:29 a.m., Devdeep Singh wrote:
> > Ship It!
Committed in master in commit 1c688f40e134e2f65fe11bb37946e550feb896ca
- Devdeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24444/#review50859
-----------------------------------------------------------
On Aug. 7, 2014, 6:13 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24444/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-7277
> https://issues.apache.org/jira/browse/CLOUDSTACK-7277
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For vmsync first VMs are listed and than their power state is determined.
> To exclude hosted system we filter the result on Caption='Virtual Machine' but this string is locale dependent so it may not
> not work properly for locales other than english. To overcome this now we started using ProcessId >= 0 filter
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 195a964
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs b2a7b45
>
> Diff: https://reviews.apache.org/r/24444/diff/
>
>
> Testing
> -------
>
> tested on my local system with ProcessId >= 0 filter VMs are syncing up properly
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 24444: CLOUDSTACK-7277: Removed the Hyper-V Agent
service dependency on english locale to sync VMs properly
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24444/#review50859
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On Aug. 7, 2014, 6:13 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24444/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-7277
> https://issues.apache.org/jira/browse/CLOUDSTACK-7277
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> For vmsync first VMs are listed and than their power state is determined.
> To exclude hosted system we filter the result on Caption='Virtual Machine' but this string is locale dependent so it may not
> not work properly for locales other than english. To overcome this now we started using ProcessId >= 0 filter
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs 195a964
> plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs b2a7b45
>
> Diff: https://reviews.apache.org/r/24444/diff/
>
>
> Testing
> -------
>
> tested on my local system with ProcessId >= 0 filter VMs are syncing up properly
>
>
> Thanks,
>
> Anshul Gangwar
>
>