You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2020/12/06 14:05:13 UTC
[GitHub] [poi] pjfanning commented on a change in pull request #203: Prototype nullability annotations
pjfanning commented on a change in pull request #203:
URL: https://github.com/apache/poi/pull/203#discussion_r537045639
##########
File path: src/java/org/apache/poi/common/usermodel/fonts/FontGroup.java
##########
@@ -42,10 +44,14 @@ Licensed to the Apache Software Foundation (ASF) under one or more
COMPLEX_SCRIPT
;
-
public static class FontGroupRange {
private int len;
- private FontGroup fontGroup;
+ private final FontGroup fontGroup;
+
+ public FontGroupRange(FontGroup fontGroup) {
Review comment:
I think it is safe to change this class now - because the 2 members are private so setting them is not really feasible from 3rd party code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org