You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "XieJiann (via GitHub)" <gi...@apache.org> on 2023/10/09 09:08:57 UTC

[PR] [feature](Nereids) covert predicate to sargable [doris]

XieJiann opened a new pull request, #25180:
URL: https://github.com/apache/doris/pull/25180

   ## Proposed changes
   
   covert predicate to sargable such as 
   ```
   (col1 + 1 - 2) / 3 = 4
   ==>
   col1 = (((4 * 3) + 2) - 1)
   ```
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1754720513

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.85 seconds
    stream load tsv:          573 seconds loaded 74807831229 Bytes, about 124 MB/s
    stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
    stream load orc:          64 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17162176995 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1753037286

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.84 seconds
    stream load tsv:          562 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
    stream load orc:          64 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
    insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
    storage size: 17162385676 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #25180:
URL: https://github.com/apache/doris/pull/25180#discussion_r1354594753


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyArithmeticComparisonRule.java:
##########
@@ -40,68 +58,90 @@
 public class SimplifyArithmeticComparisonRule extends AbstractExpressionRewriteRule {
     public static final SimplifyArithmeticComparisonRule INSTANCE = new SimplifyArithmeticComparisonRule();
 
-    @Override
-    public Expression visit(Expression expr, ExpressionRewriteContext context) {
-        return expr;
-    }
+    // don't rearrange multiplication because divide may loss precision
+    final Map<Class<? extends Expression>, Class<? extends Expression>> rearrangementMap = ImmutableMap
+            .<Class<? extends Expression>, Class<? extends Expression>>builder()
+            .put(Add.class, Subtract.class)
+            .put(Subtract.class, Add.class)
+            .put(Divide.class, Multiply.class)
+            .put(YearsSub.class, YearsAdd.class)
+            .put(YearsAdd.class, YearsSub.class)
+            .put(MonthsSub.class, MonthsAdd.class)
+            .put(MonthsAdd.class, MonthsSub.class)
+            .put(WeeksSub.class, WeeksAdd.class)
+            .put(WeeksAdd.class, WeeksSub.class)
+            .put(DaysSub.class, DaysAdd.class)
+            .put(DaysAdd.class, DaysSub.class)
+            .put(HoursSub.class, HoursAdd.class)
+            .put(HoursAdd.class, HoursSub.class)
+            .put(MinutesSub.class, MinutesAdd.class)
+            .put(MinutesAdd.class, MinutesSub.class)
+            .put(SecondsSub.class, SecondsAdd.class)
+            .put(SecondsAdd.class, SecondsSub.class)
+            .build();
 
-    private Expression process(ComparisonPredicate predicate) {
-        Expression left = predicate.left();
-        Expression right = predicate.right();
-        if (TypeUtils.isAddOrSubtract(left)) {
-            Expression p = left.child(1);
-            if (p.isConstant()) {
-                if (TypeUtils.isAdd(left)) {
-                    right = new Subtract(right, p);
-                }
-                if (TypeUtils.isSubtract(left)) {
-                    right = new Add(right, p);
-                }
-                left = left.child(0);
+    @Override
+    public Expression visitComparisonPredicate(ComparisonPredicate comparison, ExpressionRewriteContext context) {
+        ComparisonPredicate newComparison = comparison;
+        if (couldRearrange(comparison)) {
+            newComparison = normalize(comparison);
+            if (newComparison == null) {
+                return comparison;
             }
-        }
-        if (TypeUtils.isDivide(left)) {
-            Expression p = left.child(1);
-            if (p.isLiteral()) {
-                right = new Multiply(right, p);
-                left = left.child(0);
-                if (p.toString().startsWith("-")) {
-                    Expression tmp = right;
-                    right = left;
-                    left = tmp;
-                }
+            try {
+                List<Expression> children = tryRearrangeChildren(newComparison.left(), newComparison.right());
+                newComparison = (ComparisonPredicate) newComparison.withChildren(children);
+            } catch (Exception e) {
+                return comparison;
             }
         }
-        if (left != predicate.left() || right != predicate.right()) {
-            predicate = (ComparisonPredicate) predicate.withChildren(left, right);
-            return TypeCoercionUtils.processComparisonPredicate(predicate);
-        } else {
-            return predicate;
-        }
+        return TypeCoercionUtils.processComparisonPredicate(newComparison);
     }
 
-    @Override
-    public Expression visitGreaterThan(GreaterThan greaterThan, ExpressionRewriteContext context) {
-        return process(greaterThan);
+    private boolean couldRearrange(ComparisonPredicate cmp) {
+        return rearrangementMap.containsKey(cmp.left().getClass())
+                && !cmp.left().isConstant()
+                && cmp.left().children().stream().anyMatch(Expression::isConstant);
     }
 
-    @Override
-    public Expression visitGreaterThanEqual(GreaterThanEqual greaterThanEqual, ExpressionRewriteContext context) {
-        return process(greaterThanEqual);
-    }
+    private List<Expression> tryRearrangeChildren(Expression left, Expression right) throws Exception {
+        if (!left.child(1).isLiteral()) {
+            throw new RuntimeException(String.format("Expected literal when arranging children for Expr %s", left));
+        }
+        Literal leftLiteral = (Literal) left.child(1);
+        Expression leftExpr = left.child(0);
 
-    @Override
-    public Expression visitEqualTo(EqualTo equalTo, ExpressionRewriteContext context) {
-        return process(equalTo);
-    }
+        Class<? extends Expression> oppositeOperator = rearrangementMap.get(left.getClass());
+        Expression newChild = oppositeOperator.getConstructor(Expression.class, Expression.class)
+                .newInstance(right, leftLiteral);
 
-    @Override
-    public Expression visitLessThan(LessThan lessThan, ExpressionRewriteContext context) {
-        return process(lessThan);
+        if (left instanceof Divide && leftLiteral.compareTo(new IntegerLiteral(0)) < 0) {
+            // Multiplying by a negative number will change the operator.
+            return Arrays.asList(newChild, leftExpr);
+        }
+        return Arrays.asList(leftExpr, newChild);
     }
 
-    @Override
-    public Expression visitLessThanEqual(LessThanEqual lessThanEqual, ExpressionRewriteContext context) {
-        return process(lessThanEqual);
+    // Ensure that the second child must be Literal, such as
+    private @Nullable ComparisonPredicate normalize(ComparisonPredicate comparison) {

Review Comment:
   It would be better to make it public, because we could use it to generate more effecient Runtime filter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1754697005

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1752707553

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.65 seconds
    stream load tsv:          558 seconds loaded 74807831229 Bytes, about 127 MB/s
    stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
    stream load orc:          64 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.7 seconds inserted 10000000 Rows, about 348K ops/s
    storage size: 17162353504 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1752964904

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to SARGABLE [doris]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #25180:
URL: https://github.com/apache/doris/pull/25180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1756826454

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1752612711

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1757313244

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1757313305

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1752929362

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.49 seconds
    stream load tsv:          557 seconds loaded 74807831229 Bytes, about 128 MB/s
    stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
    storage size: 17162213904 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1754786544

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 45.78 seconds
    stream load tsv:          578 seconds loaded 74807831229 Bytes, about 123 MB/s
    stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17162698280 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #25180:
URL: https://github.com/apache/doris/pull/25180#discussion_r1354594753


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifyArithmeticComparisonRule.java:
##########
@@ -40,68 +58,90 @@
 public class SimplifyArithmeticComparisonRule extends AbstractExpressionRewriteRule {
     public static final SimplifyArithmeticComparisonRule INSTANCE = new SimplifyArithmeticComparisonRule();
 
-    @Override
-    public Expression visit(Expression expr, ExpressionRewriteContext context) {
-        return expr;
-    }
+    // don't rearrange multiplication because divide may loss precision
+    final Map<Class<? extends Expression>, Class<? extends Expression>> rearrangementMap = ImmutableMap
+            .<Class<? extends Expression>, Class<? extends Expression>>builder()
+            .put(Add.class, Subtract.class)
+            .put(Subtract.class, Add.class)
+            .put(Divide.class, Multiply.class)
+            .put(YearsSub.class, YearsAdd.class)
+            .put(YearsAdd.class, YearsSub.class)
+            .put(MonthsSub.class, MonthsAdd.class)
+            .put(MonthsAdd.class, MonthsSub.class)
+            .put(WeeksSub.class, WeeksAdd.class)
+            .put(WeeksAdd.class, WeeksSub.class)
+            .put(DaysSub.class, DaysAdd.class)
+            .put(DaysAdd.class, DaysSub.class)
+            .put(HoursSub.class, HoursAdd.class)
+            .put(HoursAdd.class, HoursSub.class)
+            .put(MinutesSub.class, MinutesAdd.class)
+            .put(MinutesAdd.class, MinutesSub.class)
+            .put(SecondsSub.class, SecondsAdd.class)
+            .put(SecondsAdd.class, SecondsSub.class)
+            .build();
 
-    private Expression process(ComparisonPredicate predicate) {
-        Expression left = predicate.left();
-        Expression right = predicate.right();
-        if (TypeUtils.isAddOrSubtract(left)) {
-            Expression p = left.child(1);
-            if (p.isConstant()) {
-                if (TypeUtils.isAdd(left)) {
-                    right = new Subtract(right, p);
-                }
-                if (TypeUtils.isSubtract(left)) {
-                    right = new Add(right, p);
-                }
-                left = left.child(0);
+    @Override
+    public Expression visitComparisonPredicate(ComparisonPredicate comparison, ExpressionRewriteContext context) {
+        ComparisonPredicate newComparison = comparison;
+        if (couldRearrange(comparison)) {
+            newComparison = normalize(comparison);
+            if (newComparison == null) {
+                return comparison;
             }
-        }
-        if (TypeUtils.isDivide(left)) {
-            Expression p = left.child(1);
-            if (p.isLiteral()) {
-                right = new Multiply(right, p);
-                left = left.child(0);
-                if (p.toString().startsWith("-")) {
-                    Expression tmp = right;
-                    right = left;
-                    left = tmp;
-                }
+            try {
+                List<Expression> children = tryRearrangeChildren(newComparison.left(), newComparison.right());
+                newComparison = (ComparisonPredicate) newComparison.withChildren(children);
+            } catch (Exception e) {
+                return comparison;
             }
         }
-        if (left != predicate.left() || right != predicate.right()) {
-            predicate = (ComparisonPredicate) predicate.withChildren(left, right);
-            return TypeCoercionUtils.processComparisonPredicate(predicate);
-        } else {
-            return predicate;
-        }
+        return TypeCoercionUtils.processComparisonPredicate(newComparison);
     }
 
-    @Override
-    public Expression visitGreaterThan(GreaterThan greaterThan, ExpressionRewriteContext context) {
-        return process(greaterThan);
+    private boolean couldRearrange(ComparisonPredicate cmp) {
+        return rearrangementMap.containsKey(cmp.left().getClass())
+                && !cmp.left().isConstant()
+                && cmp.left().children().stream().anyMatch(Expression::isConstant);
     }
 
-    @Override
-    public Expression visitGreaterThanEqual(GreaterThanEqual greaterThanEqual, ExpressionRewriteContext context) {
-        return process(greaterThanEqual);
-    }
+    private List<Expression> tryRearrangeChildren(Expression left, Expression right) throws Exception {
+        if (!left.child(1).isLiteral()) {
+            throw new RuntimeException(String.format("Expected literal when arranging children for Expr %s", left));
+        }
+        Literal leftLiteral = (Literal) left.child(1);
+        Expression leftExpr = left.child(0);
 
-    @Override
-    public Expression visitEqualTo(EqualTo equalTo, ExpressionRewriteContext context) {
-        return process(equalTo);
-    }
+        Class<? extends Expression> oppositeOperator = rearrangementMap.get(left.getClass());
+        Expression newChild = oppositeOperator.getConstructor(Expression.class, Expression.class)
+                .newInstance(right, leftLiteral);
 
-    @Override
-    public Expression visitLessThan(LessThan lessThan, ExpressionRewriteContext context) {
-        return process(lessThan);
+        if (left instanceof Divide && leftLiteral.compareTo(new IntegerLiteral(0)) < 0) {
+            // Multiplying by a negative number will change the operator.
+            return Arrays.asList(newChild, leftExpr);
+        }
+        return Arrays.asList(leftExpr, newChild);
     }
 
-    @Override
-    public Expression visitLessThanEqual(LessThanEqual lessThanEqual, ExpressionRewriteContext context) {
-        return process(lessThanEqual);
+    // Ensure that the second child must be Literal, such as
+    private @Nullable ComparisonPredicate normalize(ComparisonPredicate comparison) {

Review Comment:
   It would be better to make it public, because we could use it to generate more effecient Runtime filter.
   PostProcessor need this function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1754640685

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1756856860

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.93 seconds
    stream load tsv:          557 seconds loaded 74807831229 Bytes, about 128 MB/s
    stream load json:         21 seconds loaded 2358488459 Bytes, about 107 MB/s
    stream load orc:          64 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.7 seconds inserted 10000000 Rows, about 348K ops/s
    storage size: 17162225962 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](Nereids) covert predicate to sargable [doris]

Posted by "XieJiann (via GitHub)" <gi...@apache.org>.
XieJiann commented on PR #25180:
URL: https://github.com/apache/doris/pull/25180#issuecomment-1752879511

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org