You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/08/08 04:19:38 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request
#1606: Fix error DCHECK for partition_columns
morningman commented on a change in pull request #1606: Fix error DCHECK for partition_columns
URL: https://github.com/apache/incubator-doris/pull/1606#discussion_r311850253
##########
File path: be/src/exec/tablet_info.cpp
##########
@@ -171,7 +171,6 @@ Status OlapTablePartitionParam::init() {
}
_partition_slot_descs.push_back(it->second);
} else {
- DCHECK(_t_param.__isset.partition_columns);
Review comment:
Please add `else if` to make it more clear and definiteļ¼
```
} else if (_t_param.__isset.partition_columns) {
xxxx
}
```
Although without this `else if`, it still works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org