You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/26 03:20:01 UTC

[GitHub] [incubator-pinot] ly923976094 commented on a change in pull request #4006: Controller web cannot create and update schemas

ly923976094 commented on a change in pull request #4006: Controller web cannot create and update schemas 
URL: https://github.com/apache/incubator-pinot/pull/4006#discussion_r268930480
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
 ##########
 @@ -109,6 +109,7 @@ public SuccessResponse deleteSchema(
     return new SuccessResponse("Schema " + schemaName + " deleted");
   }
 
+  @Deprecated
 
 Review comment:
   The fact that it is deprecated does not mean that its functionality cannot be used. This method can still be used in places such as script creation schema, but it is suggested that this method cannot be used in controller web. Some tests will be added later

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org