You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "the-other-tim-brown (via GitHub)" <gi...@apache.org> on 2025/06/17 20:17:40 UTC
[PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
the-other-tim-brown opened a new pull request, #13451:
URL: https://github.com/apache/hudi/pull/13451
### Change Logs
- Update the test code for creating new instant times to use a specific test utility before further code cleanup. This allows us to limit the number of main codepaths that are creating instant times to ensure they are created in a uniform way.
### Impact
- Cleanup existing code
### Risk level (write none, low medium or high below)
None
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar merged PR #13451:
URL: https://github.com/apache/hudi/pull/13451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2982430796
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ade64cf3eee294780ba20f112440d9380c28b4cd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291)
* 233ba65d7056fabe1f30b5d8667f088bc70656c1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2155766132
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
+ }
+
+ private static class TestTimeGenerator implements TimeGenerator {
Review Comment:
The class is not utilized anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2984626200
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
}, {
"hash" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322",
"triggerID" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"triggerType" : "PUSH"
}, {
"hash" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6325",
"triggerID" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a68aa781b47a09a8e9445eadf9928e0e2c47bbb7 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6325)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2155768001
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
Review Comment:
Just use `HoodieInstantTimeGenerator.getCurrentInstantTimeStr` to avoid the fake `TestTimeGenerator`?
Maybe just remove the `createNewInstantTime` here and just uses `HoodieInstantTimeGenerator.getCurrentInstantTimeStr` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2981881821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ade64cf3eee294780ba20f112440d9380c28b4cd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2154484150
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime = metadataMetaClient.createNewInstantTime(false);
- if (metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime)) {
- LOG.info("Log compaction with same {} time is already present in the timeline.", logCompactionInstantTime);
Review Comment:
The time is now generated in this [part](https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java#L684) of the code and the time is generated in the write client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2167702008
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
+ }
+
+ private static class TestTimeGenerator implements TimeGenerator {
+ private static final TimeGenerator INSTANCE = new TestTimeGenerator();
+
+ @Override
+ public long generateTime(boolean skipLocking) {
+ return System.currentTimeMillis();
Review Comment:
k see the do-while
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2163784138
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
+ }
+
+ private static class TestTimeGenerator implements TimeGenerator {
+ private static final TimeGenerator INSTANCE = new TestTimeGenerator();
+
+ @Override
+ public long generateTime(boolean skipLocking) {
+ return System.currentTimeMillis();
Review Comment:
do we need a `Thread.sleep(1)` to ensure clock progresses between calls? (will add time to CI?) or implement something stateful - like having a
`private static final baseInstantTime = System.currentTimeMillis()`
and then
`return ++baseInstantTime;`
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
Review Comment:
makes sense to me, to have a class that controls time generation in the tests..
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime = metadataMetaClient.createNewInstantTime(false);
- if (metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime)) {
- LOG.info("Log compaction with same {} time is already present in the timeline.", logCompactionInstantTime);
Review Comment:
```
if (metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime))
```
I was mulling about this check.. this one here, seems to no-op the log compaction. I think we can ignore.
however, wonder if its good to add a validation inside the time generation parts (Txn Manager?) to ensure no other action with that time is requested, while holding the lock? and fail things if so. (can be in a diff PR as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2981720522
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ade64cf3eee294780ba20f112440d9380c28b4cd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2164165406
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime = metadataMetaClient.createNewInstantTime(false);
- if (metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime)) {
- LOG.info("Log compaction with same {} time is already present in the timeline.", logCompactionInstantTime);
Review Comment:
Right now we are assuming the skew guarantees uniqueness across jvms, uniqueness within a jvm is guaranteed by `HoodieInstantTimeGenerator`. I'm not sure how this condition would return true currently. It mainly looks like it is copied from the compaction case where the the instant time can be manually generated to by just before the last inflight commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2164160390
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
+ }
+
+ private static class TestTimeGenerator implements TimeGenerator {
+ private static final TimeGenerator INSTANCE = new TestTimeGenerator();
+
+ @Override
+ public long generateTime(boolean skipLocking) {
+ return System.currentTimeMillis();
Review Comment:
This is already handled by `HoodieInstantTimeGenerator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2984257172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
}, {
"hash" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322",
"triggerID" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"triggerType" : "PUSH"
}, {
"hash" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6325",
"triggerID" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bae72d879e3836b85efcdf830371ec9a5b1941b1 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322)
* a68aa781b47a09a8e9445eadf9928e0e2c47bbb7 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6325)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2981724603
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ade64cf3eee294780ba20f112440d9380c28b4cd Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2982433179
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ade64cf3eee294780ba20f112440d9380c28b4cd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291)
* 233ba65d7056fabe1f30b5d8667f088bc70656c1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2982479103
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 233ba65d7056fabe1f30b5d8667f088bc70656c1 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305)
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2982540583
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 233ba65d7056fabe1f30b5d8667f088bc70656c1 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305)
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2984026024
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
}, {
"hash" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322",
"triggerID" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312)
* bae72d879e3836b85efcdf830371ec9a5b1941b1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2984238079
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
}, {
"hash" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322",
"triggerID" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"triggerType" : "PUSH"
}, {
"hash" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bae72d879e3836b85efcdf830371ec9a5b1941b1 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322)
* a68aa781b47a09a8e9445eadf9928e0e2c47bbb7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2153758997
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -156,7 +156,7 @@ public static String getInstantFromTemporalAccessor(TemporalAccessor temporalAcc
return MILLIS_INSTANT_TIME_FORMATTER.format(temporalAccessor);
}
- public static String getCurrentInstantTimeStr() {
+ public static String getCurrentTimeAsString() {
Review Comment:
rename: currentInstantTimeString()
I prefer to keep the intent of using this as instant time - with the name.. "CurrentTime" makes it less obvious at call sites.
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java:
##########
@@ -707,42 +701,6 @@ public void testReplaceActionsTimeline() {
timeline.getCommitTimeline().getInstantsAsStream(), "Check the instants stream");
}
- @Test
- public void testCreateNewInstantTime() throws Exception {
Review Comment:
similar, can this be fixed/moved some place else
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableMetaClient.java:
##########
@@ -128,38 +124,6 @@ public void testCommitTimeline() throws IOException {
assertEquals("val", metaClient.getActiveTimeline().readCommitMetadata(completedInstant).getExtraMetadata().get("key"));
}
- @Test
Review Comment:
Add these tests to TimeGenerator or a relevant place?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime = metadataMetaClient.createNewInstantTime(false);
- if (metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime)) {
- LOG.info("Log compaction with same {} time is already present in the timeline.", logCompactionInstantTime);
Review Comment:
is this case now handled within writeClient.schedule.... ? I peeked quickly.. writeClient delegates to the table obj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2984021051
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
}, {
"hash" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312)
* bae72d879e3836b85efcdf830371ec9a5b1941b1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2154485805
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -156,7 +156,7 @@ public static String getInstantFromTemporalAccessor(TemporalAccessor temporalAcc
return MILLIS_INSTANT_TIME_FORMATTER.format(temporalAccessor);
}
- public static String getCurrentInstantTimeStr() {
+ public static String getCurrentTimeAsString() {
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2984230923
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
}, {
"hash" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322",
"triggerID" : "bae72d879e3836b85efcdf830371ec9a5b1941b1",
"triggerType" : "PUSH"
}, {
"hash" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a68aa781b47a09a8e9445eadf9928e0e2c47bbb7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312)
* bae72d879e3836b85efcdf830371ec9a5b1941b1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6322)
* a68aa781b47a09a8e9445eadf9928e0e2c47bbb7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2982477132
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ade64cf3eee294780ba20f112440d9380c28b4cd Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291)
* 233ba65d7056fabe1f30b5d8667f088bc70656c1 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305)
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2154485295
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java:
##########
@@ -707,42 +701,6 @@ public void testReplaceActionsTimeline() {
timeline.getCommitTimeline().getInstantsAsStream(), "Check the instants stream");
}
- @Test
- public void testCreateNewInstantTime() throws Exception {
Review Comment:
Yes, moved this to `TestHoodieInstantTimeGenerator`
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableMetaClient.java:
##########
@@ -128,38 +124,6 @@ public void testCommitTimeline() throws IOException {
assertEquals("val", metaClient.getActiveTimeline().readCommitMetadata(completedInstant).getExtraMetadata().get("key"));
}
- @Test
Review Comment:
Moved this to `TestHoodieInstantTimeGenerator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13451:
URL: https://github.com/apache/hudi/pull/13451#issuecomment-2982711499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6291",
"triggerID" : "ade64cf3eee294780ba20f112440d9380c28b4cd",
"triggerType" : "PUSH"
}, {
"hash" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6305",
"triggerID" : "233ba65d7056fabe1f30b5d8667f088bc70656c1",
"triggerType" : "PUSH"
}, {
"hash" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312",
"triggerID" : "3fb180ac784acdbf2e12761127d5f9bc31c7a332",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fb180ac784acdbf2e12761127d5f9bc31c7a332 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=6312)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2155766132
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
+ }
+
+ private static class TestTimeGenerator implements TimeGenerator {
Review Comment:
The class is not utilized anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2155768001
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
Review Comment:
Just use `HoodieInstantTimeGenerator.getCurrentInstantTimeStr` to avoid the fake `TestTimeGenerator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-9476] Update test usage of createNewInstantTime [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2159207303
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/WriteClientTestUtils.java:
##########
@@ -40,4 +43,22 @@ public static void startCommitWithTime(BaseHoodieWriteClient<?, ?, ?, ?> writeCl
public static Option<String> scheduleTableService(BaseHoodieWriteClient<?, ?, ?, ?> writeClient, String instantTime, Option<Map<String, String>> extraMetadata, TableServiceType tableServiceType) {
return writeClient.scheduleTableService(Option.of(instantTime), extraMetadata, tableServiceType);
}
+
+ public static String createNewInstantTime() {
+ return HoodieInstantTimeGenerator.createNewInstantTime(false, TestTimeGenerator.INSTANCE, 0);
Review Comment:
This path has the added benefit of ensuring that the instant times are unique by going through the checks in `HoodieInstantTimeGenerator`. Without this, there is some flakiness in the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org