You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jay Kreps (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 09:15:28 UTC
[jira] [Created] (KAFKA-322) Remove one-off Send objects
Remove one-off Send objects
---------------------------
Key: KAFKA-322
URL: https://issues.apache.org/jira/browse/KAFKA-322
Project: Kafka
Issue Type: Improvement
Components: core
Affects Versions: 0.8
Reporter: Jay Kreps
Assignee: Jay Kreps
Priority: Minor
Fix For: 0.8
We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example:
ProducerResponseSend.scala
It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call.
I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-322) Remove one-off Send objects
Posted by "Neha Narkhede (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede updated KAFKA-322:
--------------------------------
Labels: replication (was: )
> Remove one-off Send objects
> ---------------------------
>
> Key: KAFKA-322
> URL: https://issues.apache.org/jira/browse/KAFKA-322
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8
> Reporter: Jay Kreps
> Assignee: Jay Kreps
> Priority: Minor
> Labels: replication
> Fix For: 0.8
>
>
> We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example:
> ProducerResponseSend.scala
> It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call.
> I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira