You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Benedict (JIRA)" <ji...@apache.org> on 2015/05/28 07:41:22 UTC

[jira] [Commented] (CASSANDRA-8584) Add rate limited logging of failed trySkipCache calls and commit log lag

    [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562322#comment-14562322 ] 

Benedict commented on CASSANDRA-8584:
-------------------------------------

That seems reasonable. However there are now a lot of failures on cassci for your branch (possibly due to something else, ofc, but it looks like it may have not been rebased)

> Add rate limited logging of failed trySkipCache calls and commit log lag
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Ariel Weisberg
>            Priority: Trivial
>             Fix For: 2.1.x
>
>         Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary calls, it's thread-safe and we could print out more helpful information if we failed to prompt the kernel to skip the page cache.  That system call should always succeed unless we have an invalid fd as it's free to ignore us.
> Commit log lag is already rate limited by its own implementation. Convert to use NoSpamLogger.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)